Re: [RFC 1/7] pinctrl: sh-pfc: r8a7790: Implement voltage switching for SDHI

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]

> Shouldn't the "From" line have Ben's authorship, too?

I considered the changes to this patch significant enough to take over
ownership. Even more so with the changes you suggested.

> > @Uli, Geert: Since bias support is probably similar, what do you think? Does
> > it make sense to add gen{2,3}.c?
> 
> It's up to you.
> We can always consolidate later.

Then let's start like this and see later if consolidation is really needed.

> > @@ -4691,6 +4696,53 @@ static const char * const vin3_groups[] = {
> >         "vin3_clk",
> >  };
> >
> > +#define IOCTRL6 0xe606008c
> 
> ... if you use 0x8c here...
> 
> > +static int r8a7790_get_io_voltage(struct sh_pfc *pfc, unsigned int pin)
> > +{
> > +       void __iomem *reg;
> > +       u32 data, mask;
> > +
> > +       if (WARN(pin < RCAR_GP_PIN(3, 0) || pin > RCAR_GP_PIN(3, 31), "invalid pin %#x", pin))
> > +               return -EINVAL;
> > +
> > +       reg = sh_pfc_phys_to_virt(pfc, IOCTRL6);
> 
> ... and use "pfc->windows->virt + IOCTRL6" here and in
> r8a7790_set_io_voltage(), cfr. r8a7778_pinmux_get_bias().

I see. I thought sh_pfc_phys_to_virt was more correct because it
iterates over all possible windows. But yeah, we can probably live with
the simpler approach on Gen2/3. Will change.

Thanks for the review,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]