From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
linux-renesas-soc@vger.kernel.org, linux-mmc@vger.kernel.org,
magnus.damm@gmail.com
Subject: Re: [PATCH] ARM: dts: r8a7793: Add MMCIF0
Date: Thu, 17 Mar 2016 09:29:08 +0900 [thread overview]
Message-ID: <20160317002907.GC17728@verge.net.au> (raw)
In-Reply-To: <56E995EE.2010805@cogentembedded.com>
On Wed, Mar 16, 2016 at 08:20:46PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 03/16/2016 08:10 PM, Ulrich Hecht wrote:
>
> >Same as on r8a7794.
Thanks, I'm pleased to see this.
Its been on my todo list for a while.
> >
> >Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> >---
> > arch/arm/boot/dts/r8a7793.dtsi | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> >index 63f811d..33413e8 100644
> >--- a/arch/arm/boot/dts/r8a7793.dtsi
> >+++ b/arch/arm/boot/dts/r8a7793.dtsi
> >@@ -509,6 +509,18 @@
> > reg = <0 0xe6060000 0 0x250>;
> > };
> >
> >+ mmcif0: mmcif@ee200000 {
> >+ compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
> >+ reg = <0 0xee200000 0 0x80>;
> >+ interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
> >+ clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
> >+ dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
> >+ <&dmac1 0xd1>, <&dmac1 0xd2>;
> >+ dma-names = "tx", "rx";
>
> 4 DMA channels but only 2 channel names?
Right, it looks like it should be:
dma-names = "tx", "rx", "tx", "rx";
Ulrich, could you verify that and repost?
next prev parent reply other threads:[~2016-03-17 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 17:10 [PATCH] ARM: dts: r8a7793: Add MMCIF0 Ulrich Hecht
2016-03-16 17:20 ` Sergei Shtylyov
2016-03-17 0:29 ` Simon Horman [this message]
2016-03-17 1:23 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317002907.GC17728@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox