From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
linux-renesas-soc@vger.kernel.org, linux-mmc@vger.kernel.org,
magnus.damm@gmail.com
Subject: Re: [PATCH 1/2] ARM: dts: r8a7793: Add SDHI controllers
Date: Thu, 17 Mar 2016 10:23:50 +0900 [thread overview]
Message-ID: <20160317012350.GD17728@verge.net.au> (raw)
In-Reply-To: <56E99645.10504@cogentembedded.com>
On Wed, Mar 16, 2016 at 08:22:13PM +0300, Sergei Shtylyov wrote:
> On 03/16/2016 08:11 PM, Ulrich Hecht wrote:
>
> >Same as on r8a7791.
> >
> >Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> >---
> > arch/arm/boot/dts/r8a7793.dtsi | 33 +++++++++++++++++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> >index b7f32d3..009ce38 100644
> >--- a/arch/arm/boot/dts/r8a7793.dtsi
> >+++ b/arch/arm/boot/dts/r8a7793.dtsi
> >@@ -509,6 +509,39 @@
> > reg = <0 0xe6060000 0 0x250>;
> > };
> >
> >+ sdhi0: sd@ee100000 {
> >+ compatible = "renesas,sdhi-r8a7793";
> >+ reg = <0 0xee100000 0 0x328>;
> >+ interrupts = <0 165 IRQ_TYPE_LEVEL_HIGH>;
> >+ clocks = <&mstp3_clks R8A7793_CLK_SDHI0>;
> >+ dmas = <&dmac0 0xcd>, <&dmac0 0xce>,
> >+ <&dmac1 0xcd>, <&dmac1 0xce>;
> >+ dma-names = "tx", "rx";
>
> 4 DMA channels but only 2 channel names?
It looks like that should be:
dma-names = "tx", "rx", "tx", "rx";
It also looks like there should be:
power-domains = <&cpg_clocks>;
Ulrich, could you verify the above and repost as necessary?
next prev parent reply other threads:[~2016-03-17 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 17:11 [PATCH 0/2] ARM: dts: r8a7793/gose: enable SDHI Ulrich Hecht
2016-03-16 17:11 ` [PATCH 1/2] ARM: dts: r8a7793: Add SDHI controllers Ulrich Hecht
2016-03-16 17:22 ` Sergei Shtylyov
2016-03-17 1:23 ` Simon Horman [this message]
2016-03-16 17:11 ` [PATCH 2/2] ARM: dts: gose: Enable " Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317012350.GD17728@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox