* [PATCH] ARM: dts: r8a7793: Add MMCIF0
@ 2016-03-16 17:10 Ulrich Hecht
2016-03-16 17:20 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Ulrich Hecht @ 2016-03-16 17:10 UTC (permalink / raw)
To: horms; +Cc: linux-renesas-soc, linux-mmc, magnus.damm, Ulrich Hecht
Same as on r8a7794.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
arch/arm/boot/dts/r8a7793.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index 63f811d..33413e8 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -509,6 +509,18 @@
reg = <0 0xe6060000 0 0x250>;
};
+ mmcif0: mmcif@ee200000 {
+ compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
+ reg = <0 0xee200000 0 0x80>;
+ interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
+ dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
+ <&dmac1 0xd1>, <&dmac1 0xd2>;
+ dma-names = "tx", "rx";
+ reg-io-width = <4>;
+ status = "disabled";
+ };
+
scifa0: serial@e6c40000 {
compatible = "renesas,scifa-r8a7793",
"renesas,rcar-gen2-scifa", "renesas,scifa";
--
2.6.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: r8a7793: Add MMCIF0
2016-03-16 17:10 [PATCH] ARM: dts: r8a7793: Add MMCIF0 Ulrich Hecht
@ 2016-03-16 17:20 ` Sergei Shtylyov
2016-03-17 0:29 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2016-03-16 17:20 UTC (permalink / raw)
To: Ulrich Hecht, horms; +Cc: linux-renesas-soc, linux-mmc, magnus.damm
Hello.
On 03/16/2016 08:10 PM, Ulrich Hecht wrote:
> Same as on r8a7794.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> arch/arm/boot/dts/r8a7793.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> index 63f811d..33413e8 100644
> --- a/arch/arm/boot/dts/r8a7793.dtsi
> +++ b/arch/arm/boot/dts/r8a7793.dtsi
> @@ -509,6 +509,18 @@
> reg = <0 0xe6060000 0 0x250>;
> };
>
> + mmcif0: mmcif@ee200000 {
> + compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
> + reg = <0 0xee200000 0 0x80>;
> + interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
> + dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
> + <&dmac1 0xd1>, <&dmac1 0xd2>;
> + dma-names = "tx", "rx";
4 DMA channels but only 2 channel names?
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: r8a7793: Add MMCIF0
2016-03-16 17:20 ` Sergei Shtylyov
@ 2016-03-17 0:29 ` Simon Horman
2016-03-17 1:23 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2016-03-17 0:29 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Ulrich Hecht, linux-renesas-soc, linux-mmc, magnus.damm
On Wed, Mar 16, 2016 at 08:20:46PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 03/16/2016 08:10 PM, Ulrich Hecht wrote:
>
> >Same as on r8a7794.
Thanks, I'm pleased to see this.
Its been on my todo list for a while.
> >
> >Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> >---
> > arch/arm/boot/dts/r8a7793.dtsi | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> >index 63f811d..33413e8 100644
> >--- a/arch/arm/boot/dts/r8a7793.dtsi
> >+++ b/arch/arm/boot/dts/r8a7793.dtsi
> >@@ -509,6 +509,18 @@
> > reg = <0 0xe6060000 0 0x250>;
> > };
> >
> >+ mmcif0: mmcif@ee200000 {
> >+ compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
> >+ reg = <0 0xee200000 0 0x80>;
> >+ interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
> >+ clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
> >+ dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
> >+ <&dmac1 0xd1>, <&dmac1 0xd2>;
> >+ dma-names = "tx", "rx";
>
> 4 DMA channels but only 2 channel names?
Right, it looks like it should be:
dma-names = "tx", "rx", "tx", "rx";
Ulrich, could you verify that and repost?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: r8a7793: Add MMCIF0
2016-03-17 0:29 ` Simon Horman
@ 2016-03-17 1:23 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2016-03-17 1:23 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Ulrich Hecht, linux-renesas-soc, linux-mmc, magnus.damm
On Thu, Mar 17, 2016 at 09:29:08AM +0900, Simon Horman wrote:
> On Wed, Mar 16, 2016 at 08:20:46PM +0300, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 03/16/2016 08:10 PM, Ulrich Hecht wrote:
> >
> > >Same as on r8a7794.
>
> Thanks, I'm pleased to see this.
> Its been on my todo list for a while.
>
> > >
> > >Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> > >---
> > > arch/arm/boot/dts/r8a7793.dtsi | 12 ++++++++++++
> > > 1 file changed, 12 insertions(+)
> > >
> > >diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> > >index 63f811d..33413e8 100644
> > >--- a/arch/arm/boot/dts/r8a7793.dtsi
> > >+++ b/arch/arm/boot/dts/r8a7793.dtsi
> > >@@ -509,6 +509,18 @@
> > > reg = <0 0xe6060000 0 0x250>;
> > > };
> > >
> > >+ mmcif0: mmcif@ee200000 {
> > >+ compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
> > >+ reg = <0 0xee200000 0 0x80>;
> > >+ interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
> > >+ clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
> > >+ dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
> > >+ <&dmac1 0xd1>, <&dmac1 0xd2>;
> > >+ dma-names = "tx", "rx";
> >
> > 4 DMA channels but only 2 channel names?
>
> Right, it looks like it should be:
>
> dma-names = "tx", "rx", "tx", "rx";
>
> Ulrich, could you verify that and repost?
One more thing. I think you also need a power domains property:
power-domains = <&cpg_clocks>;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-17 1:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-16 17:10 [PATCH] ARM: dts: r8a7793: Add MMCIF0 Ulrich Hecht
2016-03-16 17:20 ` Sergei Shtylyov
2016-03-17 0:29 ` Simon Horman
2016-03-17 1:23 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox