From: Mark Brown <broonie@kernel.org>
To: Bjorn Andersson <bjorn@kryo.se>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 2/2] regulator: core: Ensure we are at least in bounds for our constraints
Date: Sun, 27 Mar 2016 10:08:59 +0100 [thread overview]
Message-ID: <20160327090859.GH5028@sirena.org.uk> (raw)
In-Reply-To: <CAJAp7OgGQ3qm-_QhydvN0n6QeNoHFdso4zOk41qvVJhKNeRn8Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On Sat, Mar 26, 2016 at 04:50:41PM -0700, Bjorn Andersson wrote:
> Reinstating the following snippet in of_get_regulation_constraints()
> sort this out:
> if (constraints->min_uV && constraints->max_uV)
> constraints->apply_uV = true;
The existing check in the patch should be an || not an ==, or possibly
we should just not bother looking for min_uV at all. I just pushed out
a version of that, let's see how that goes.
> I did look at an alternative of having regulator_set_voltage() pass
> and call set_voltage() if the requested voltage matches the
> constraints, but this does indeed seem to mess things up. So checking
> in with you before continuing on that hack.
Yes, not everything is writeable.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-27 9:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1458587912-32665-1-git-send-email-broonie@kernel.org>
[not found] ` <1458587912-32665-2-git-send-email-broonie@kernel.org>
[not found] ` <56F0624C.8010004@gmail.com>
2016-03-24 6:11 ` [PATCH 2/2] regulator: core: Ensure we are at least in bounds for our constraints Krzysztof Kozlowski
2016-03-24 7:18 ` Krzysztof Kozlowski
2016-03-26 23:50 ` Bjorn Andersson
2016-03-27 9:08 ` Mark Brown [this message]
2016-03-28 16:16 ` Bjorn Andersson
2016-03-29 12:00 ` Geert Uytterhoeven
2016-03-29 14:58 ` Mark Brown
2016-03-29 18:05 ` Geert Uytterhoeven
2016-03-29 18:27 ` Mark Brown
2016-03-30 9:07 ` Haibo Chen
2016-03-30 15:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160327090859.GH5028@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn@kryo.se \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox