From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bjorn Andersson <bjorn@kryo.se>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: core: Ensure we are at least in bounds for our constraints
Date: Tue, 29 Mar 2016 07:58:23 -0700 [thread overview]
Message-ID: <20160329145823.GK2350@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdXuy2TxACTcsgOpZvrJEeTSQbCgCUmS9PXfBhhZfgbBBA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
On Tue, Mar 29, 2016 at 02:00:52PM +0200, Geert Uytterhoeven wrote:
> On Sun, Mar 27, 2016 at 11:08 AM, Mark Brown <broonie@kernel.org> wrote:
> > The existing check in the patch should be an || not an ==, or possibly
> > we should just not bother looking for min_uV at all. I just pushed out
> > a version of that, let's see how that goes.
> Has the fix really been pushed out?
Yes.
> WARNING: CPU: 1 PID: 31 at drivers/regulator/core.c:2223
> _regulator_disable+0x2c/0x128
> unbalanced disables for SDHI0 VccQ
> when booting on r8a7791/koelsch.
This seems like a bug somewhere else in your code, we're looking at
changes in the voltage setting code but this is an unbalanced disable.
> I'm a bit confused by the discussion of "&&" vs. "||" vs. "==", but the
> warnings do go away when using "!=", cfr. the whitespace-damaged patch below.
> /* Voltage change possible? */
> - if (constraints->min_uV && constraints->max_uV) {
> + if (constraints->min_uV != constraints->max_uV) {
Do you have constraints that specify a maximum voltage but no minimum
(which I'd say are broken), or constraints that are just plain wrong but
are now being applied like specifying the entire range of the regulator?
The above might be some follow on error handling from something that
happened the change in handling of the constraints. You need to look at
what the relevant regulator constraints are...
Previously both voltages needed to be non-zero and equal for anything to
happen, now they only need to both be non-zero.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-29 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1458587912-32665-1-git-send-email-broonie@kernel.org>
[not found] ` <1458587912-32665-2-git-send-email-broonie@kernel.org>
[not found] ` <56F0624C.8010004@gmail.com>
2016-03-24 6:11 ` [PATCH 2/2] regulator: core: Ensure we are at least in bounds for our constraints Krzysztof Kozlowski
2016-03-24 7:18 ` Krzysztof Kozlowski
2016-03-26 23:50 ` Bjorn Andersson
2016-03-27 9:08 ` Mark Brown
2016-03-28 16:16 ` Bjorn Andersson
2016-03-29 12:00 ` Geert Uytterhoeven
2016-03-29 14:58 ` Mark Brown [this message]
2016-03-29 18:05 ` Geert Uytterhoeven
2016-03-29 18:27 ` Mark Brown
2016-03-30 9:07 ` Haibo Chen
2016-03-30 15:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329145823.GK2350@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn@kryo.se \
--cc=geert@linux-m68k.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox