[PATCH v2] ARM: dts: r8a7793: Add MMCIF0

[PATCH v2] ARM: dts: r8a7793: Add MMCIF0

[Ulrich Hecht]

Same as on r8a7794.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
This revision adds the missing dma-names and power-domains entires spotted
by Sergei and Simon.

CU
Uli


 arch/arm/boot/dts/r8a7793.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index bf70c46..6843f46 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -510,6 +510,19 @@
 		reg = <0 0xe6060000 0 0x250>;
 	};
 
+	mmcif0: mmcif@ee200000 {
+		compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
+		reg = <0 0xee200000 0 0x80>;
+		interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
+		dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
+		       <&dmac1 0xd1>, <&dmac1 0xd2>;
+		dma-names = "tx", "rx", "tx", "rx";
+		power-domains = <&cpg_clocks>;
+		reg-io-width = <4>;
+		status = "disabled";
+	};
+
 	scifa0: serial@e6c40000 {
 		compatible = "renesas,scifa-r8a7793",
 			     "renesas,rcar-gen2-scifa", "renesas,scifa";
-- 
2.7.4

Re: [PATCH v2] ARM: dts: r8a7793: Add MMCIF0

[Simon Horman]

On Mon, Apr 18, 2016 at 06:02:40PM +0200, Ulrich Hecht wrote:
> Same as on r8a7794.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> This revision adds the missing dma-names and power-domains entires spotted
> by Sergei and Simon.

Thanks, we are back to one using one dma controller for now so I adjusted
your patch and queued up the following:

From: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Date: Mon, 18 Apr 2016 18:02:40 +0200
Subject: [PATCH] ARM: dts: r8a7793: Add MMCIF0

Same as on r8a7794.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7793.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index bddc31283bd9..fc552629ed4a 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -507,6 +507,18 @@
 		reg = <0 0xe6060000 0 0x250>;
 	};
 
+	mmcif0: mmcif@ee200000 {
+		compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
+		reg = <0 0xee200000 0 0x80>;
+		interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
+		dmas = <&dmac0 0xd1>, <&dmac0 0xd2>;
+		dma-names = "tx", "rx";
+		power-domains = <&cpg_clocks>;
+		reg-io-width = <4>;
+		status = "disabled";
+	};
+
 	scifa0: serial@e6c40000 {
 		compatible = "renesas,scifa-r8a7793",
 			     "renesas,rcar-gen2-scifa", "renesas,scifa";
-- 
2.7.0.rc3.207.g0ac5344

Re: [PATCH v2] ARM: dts: r8a7793: Add MMCIF0

[Geert Uytterhoeven]

On Mon, Apr 18, 2016 at 6:02 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Same as on r8a7794.

r8a7791?

> --- a/arch/arm/boot/dts/r8a7793.dtsi
> +++ b/arch/arm/boot/dts/r8a7793.dtsi
> @@ -510,6 +510,19 @@
>                 reg = <0 0xe6060000 0 0x250>;
>         };
>
> +       mmcif0: mmcif@ee200000 {
> +               compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
> +               reg = <0 0xee200000 0 0x80>;
> +               interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;

s/0/GIC_SPI/

> +               clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
> +               dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
> +                      <&dmac1 0xd1>, <&dmac1 0xd2>;
> +               dma-names = "tx", "rx", "tx", "rx";
> +               power-domains = <&cpg_clocks>;
> +               reg-io-width = <4>;
> +               status = "disabled";

max-frequency = <97500000>;?

It's always a good idea to compare r8a7791.dts and r8a7793.dtsi
after s/r8a779[13]/r8a779x/...

> +       };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] ARM: dts: r8a7793: Add MMCIF0

[Simon Horman]

On Thu, Apr 21, 2016 at 02:52:09PM +0200, Geert Uytterhoeven wrote:
> On Mon, Apr 18, 2016 at 6:02 PM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
> > Same as on r8a7794.
> 
> r8a7791?
> 
> > --- a/arch/arm/boot/dts/r8a7793.dtsi
> > +++ b/arch/arm/boot/dts/r8a7793.dtsi
> > @@ -510,6 +510,19 @@
> >                 reg = <0 0xe6060000 0 0x250>;
> >         };
> >
> > +       mmcif0: mmcif@ee200000 {
> > +               compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
> > +               reg = <0 0xee200000 0 0x80>;
> > +               interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
> 
> s/0/GIC_SPI/
> 
> > +               clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
> > +               dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
> > +                      <&dmac1 0xd1>, <&dmac1 0xd2>;
> > +               dma-names = "tx", "rx", "tx", "rx";
> > +               power-domains = <&cpg_clocks>;
> > +               reg-io-width = <4>;
> > +               status = "disabled";
> 
> max-frequency = <97500000>;?
> 
> It's always a good idea to compare r8a7791.dts and r8a7793.dtsi
> after s/r8a779[13]/r8a779x/...
> 
> > +       };

Thanks Geert,

it looks like I was a little hasty in queueing up this patch.
I have dropped it for now. 

Ulrich,

please address the feedback and repost.

Thanks