Re: [PATCH v2] ARM: dts: r8a7793: Add MMCIF0

[Simon Horman <horms@verge.net.au>]

On Thu, Apr 21, 2016 at 02:52:09PM +0200, Geert Uytterhoeven wrote:
> On Mon, Apr 18, 2016 at 6:02 PM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
> > Same as on r8a7794.
> 
> r8a7791?
> 
> > --- a/arch/arm/boot/dts/r8a7793.dtsi
> > +++ b/arch/arm/boot/dts/r8a7793.dtsi
> > @@ -510,6 +510,19 @@
> >                 reg = <0 0xe6060000 0 0x250>;
> >         };
> >
> > +       mmcif0: mmcif@ee200000 {
> > +               compatible = "renesas,mmcif-r8a7793", "renesas,sh-mmcif";
> > +               reg = <0 0xee200000 0 0x80>;
> > +               interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
> 
> s/0/GIC_SPI/
> 
> > +               clocks = <&mstp3_clks R8A7793_CLK_MMCIF0>;
> > +               dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
> > +                      <&dmac1 0xd1>, <&dmac1 0xd2>;
> > +               dma-names = "tx", "rx", "tx", "rx";
> > +               power-domains = <&cpg_clocks>;
> > +               reg-io-width = <4>;
> > +               status = "disabled";
> 
> max-frequency = <97500000>;?
> 
> It's always a good idea to compare r8a7791.dts and r8a7793.dtsi
> after s/r8a779[13]/r8a779x/...
> 
> > +       };

Thanks Geert,

it looks like I was a little hasty in queueing up this patch.
I have dropped it for now. 

Ulrich,

please address the feedback and repost.

Thanks