From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Ai Kyuse <ai.kyuse.uw@renesas.com>
Subject: Re: [PATCH v3 1/4] mmc: tmio: enhance illegal sequence handling
Date: Fri, 27 May 2016 13:34:15 +0200 [thread overview]
Message-ID: <20160527113415.GB1663@katana> (raw)
In-Reply-To: <1464057797-29951-2-git-send-email-horms+renesas@verge.net.au>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Tue, May 24, 2016 at 11:43:14AM +0900, Simon Horman wrote:
> From: Ai Kyuse <ai.kyuse.uw@renesas.com>
>
> An illegal sequence command error may occur if there is a stopbit or
> cmd_index error as well as a CRC error. The correct course of action
> is to re-enable IRQs
>
> An illegal sequence data error may occur if there is a CRC or stopbit
> error, or underrun. In this case set data->error correctly.
>
> This is in preparation for enabling tuning support which relies on
> differentiating between illegal sequence and other errors.
>
> Signed-off-by: Ai Kyuse <ai.kyuse.uw@renesas.com>
> [simon: broken out of a larger patch]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Breaking out this one really helps the understanding and the review of
the series. Thanks for doing it!
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-27 11:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 2:43 [PATCH v3 0/4] UHS-I SDR-104 support for sh_mobile_sdhi Simon Horman
2016-05-24 2:43 ` [PATCH v3 1/4] mmc: tmio: enhance illegal sequence handling Simon Horman
2016-05-27 11:34 ` Wolfram Sang [this message]
2016-05-24 2:43 ` [PATCH v3 2/4] mmc: tmio: Add tuning support Simon Horman
2016-05-27 11:47 ` Wolfram Sang
2016-05-24 2:43 ` [PATCH v3 3/4] mmc: sh_mobile_sdhi: " Simon Horman
2016-05-27 11:59 ` Wolfram Sang
2016-07-20 6:24 ` Simon Horman
2016-05-31 10:39 ` Geert Uytterhoeven
2016-06-06 1:02 ` Simon Horman
2016-05-24 2:43 ` [PATCH v3 4/4] ARM: dts: r8a7790: lager: Enable UHS-I SDR-104 Simon Horman
2016-05-27 12:03 ` [PATCH v3 0/4] UHS-I SDR-104 support for sh_mobile_sdhi Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527113415.GB1663@katana \
--to=wsa@the-dreams.de \
--cc=ai.kyuse.uw@renesas.com \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox