linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	jacob.jun.pan@intel.com, dave.hansen@linux.intel.com,
	adrian.hunter@intel.com, ak@linux.intel.com, luto@kernel.org,
	bp@alien8.de, dvhart@infradead.org, dougthompson@xmission.com,
	edubezval@gmail.com, hpa@zytor.com, mingo@redhat.com,
	jacob.jun.pan@linux.intel.com, kan.liang@intel.com,
	lenb@kernel.org, linux-acpi@vger.kernel.org,
	linux-edac@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-pm@vger.kernel.org, mchehab@osg.samsung.com,
	peterz@infradead.org, platform-driver-x86@vger.kernel.org,
	rafael.j.wysocki@intel.com, rajneesh.bhardwaj@intel.com,
	souvik.k.chakravarty@intel.com,
	srinivas.pandruvada@linux.intel.com, eranian@google.com,
	tglx@linutronix.de, tony.luck@intel.com, ulf.hansson@linaro.org,
	viresh.kumar@linaro.org, vishwanath.somayaji@intel.com,
	rui.zhang@intel.com
Subject: Re: [PATCH 01/20] [v2] x86, intel: Introduce macros for Intel family numbers
Date: Wed, 8 Jun 2016 13:01:47 +0200	[thread overview]
Message-ID: <20160608110147.GA32077@gmail.com> (raw)
In-Reply-To: <20160603001927.F2A7D828@viggo.jf.intel.com>


* Dave Hansen <dave@sr71.net> wrote:

> 
> Changes from v1:
>  * added acks from a few folks
>  * Took the redundant "MODEL_" out of the macro names (Suggested
>    by Borislav Petkov and acked by others)
> 
> From: Dave Hansen <dave.hansen@linux.intel.com>
> 
> If you are cc'd on this code, please check _your_ code vs. the
> model list in "intel-family.h".  Please make sure you have all
> the models listed that you intend to.
> 
> Also, rather than trickling these in via all the various
> maintainers, should these just get pulled in to the x86 tree in
> one go?
> 
> Problem:
> 
> We have a boatload of open-coded family-6 model numbers.  Half of
> them have these model numbers in hex and the other half in
> decimal.  This makes grepping for them tons of fun, if you were
> to try.
> 
> Solution:
> 
> Consolidate all the magic numbers.  Put all the definitions in
> one header.
> 
> The names here are closely derived from the comments describing
> the models from arch/x86/events/intel/core.c.  We could easily
> make them shorter by doing things like s/SANDYBRIDGE/SNB/, but
> they seemed fine even with the longer versions to me.
> 
> Do not take any of these names too literally, like "DESKTOP"
> or "MOBILE".  These are all colloquial names and not precise
> descriptions of everywhere a given model will show up.
> 
> These have all been compile-tested.  I also made a stab at
> dumping .o files and looking for unexpected deltas when I was
> just replacing magic numbers with equivalent macros.

So I've picked up this series and restructured it: I've created a single patch 
that creates intel-family.h and have put it into x86/urgent. This eliminated 
dependencies and allowed some of the patches to be queued in their natural trees, 
in particular the 7 perf patches.

Thanks,

	Ingo

      parent reply	other threads:[~2016-06-08 11:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03  0:19 [PATCH 01/20] [v2] x86, intel: Introduce macros for Intel family numbers Dave Hansen
2016-06-03  0:19 ` [PATCH 17/20] x86, mmc: use Intel family name macros for mmc driver Dave Hansen
2016-06-03  0:38 ` [PATCH 01/20] [v2] x86, intel: Introduce macros for Intel family numbers Rafael J. Wysocki
2016-06-08 11:01 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160608110147.GA32077@gmail.com \
    --to=mingo@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave@sr71.net \
    --cc=dougthompson@xmission.com \
    --cc=dvhart@infradead.org \
    --cc=edubezval@gmail.com \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=jacob.jun.pan@intel.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=kan.liang@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rajneesh.bhardwaj@intel.com \
    --cc=rui.zhang@intel.com \
    --cc=souvik.k.chakravarty@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=ulf.hansson@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vishwanath.somayaji@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).