From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH/RFC 2/4] mmc: renesas_sdhi, tmio: make dma more modular
Date: Wed, 22 Jun 2016 16:13:11 +0200 [thread overview]
Message-ID: <20160622141311.GB1645@katana> (raw)
In-Reply-To: <1465963317-28672-3-git-send-email-horms+renesas@verge.net.au>
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
> +#if IS_ENABLED(CONFIG_MMC_SDHI_DMA)
> +int tmio_mmc_init_dma(void);
> +#else
> +static int tmio_mmc_init_dma(void)
> +{
> + return -EINVAL;
> +}
> +#endif
Can't we make this another tmio_mmc_dma_ops to save the ifdeffery?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-22 14:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 4:01 [PATCH/RFC 0/4] mmc: renesas_sdhi: add R-Car Gen-3 DMA support Simon Horman
2016-06-15 4:01 ` [PATCH/RFC 1/4] mmc: renesas_sdhi: rename sh_mobile_sdhi as renesas_sdhi Simon Horman
2016-06-22 14:11 ` Wolfram Sang
2016-06-15 4:01 ` [PATCH/RFC 2/4] mmc: renesas_sdhi, tmio: make dma more modular Simon Horman
2016-06-22 14:13 ` Wolfram Sang [this message]
2016-06-15 4:01 ` [PATCH/RFC 3/4] mmc: renesas_sdhi: rename DMA source file as renesas_sdhi_dma.c Simon Horman
2016-06-22 14:21 ` Wolfram Sang
2016-06-15 4:01 ` [PATCH/RFC 4/4] mmc: renesas_sdhi: add support for R-Car Gen3 SDHI DMAC Simon Horman
2016-06-27 12:18 ` Wolfram Sang
2016-06-27 12:17 ` [PATCH/RFC 0/4] mmc: renesas_sdhi: add R-Car Gen-3 DMA support Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622141311.GB1645@katana \
--to=wsa@the-dreams.de \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox