From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH/RFC 3/4] mmc: renesas_sdhi: rename DMA source file as renesas_sdhi_dma.c
Date: Wed, 22 Jun 2016 16:21:10 +0200 [thread overview]
Message-ID: <20160622142110.GC1645@katana> (raw)
In-Reply-To: <1465963317-28672-4-git-send-email-horms+renesas@verge.net.au>
[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]
On Wed, Jun 15, 2016 at 01:01:56PM +0900, Simon Horman wrote:
> Rename the source file for DMA for Renesas SDHI as a follow-up to attaching
> DMA code to the renesas_sdhi driver rather than the tmio_core driver.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/mmc/host/Makefile | 2 +-
> drivers/mmc/host/{tmio_mmc_dma.c => renesas_sdhi_dma.c} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename drivers/mmc/host/{tmio_mmc_dma.c => renesas_sdhi_dma.c} (100%)
Because of the modularization, I think the rename makes a lot of sense
here and is worth renaming the functions inside, too. What do you think?
I think the rename should include the DMA type used, though. Like
'renesas_sdhi_sysc_dmac.c' here and 'renesas_sdhi_internal_dmac.c' for
the new one in the next patch?
>
> diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile
> index 4f7903fbef26..0ea7fb6f3d5e 100644
> --- a/drivers/mmc/host/Makefile
> +++ b/drivers/mmc/host/Makefile
> @@ -38,7 +38,7 @@ obj-$(CONFIG_MMC_TMIO) += tmio_mmc.o
> obj-$(CONFIG_MMC_TMIO_CORE) += tmio_mmc_core.o
> tmio_mmc_core-y := tmio_mmc_pio.o
> obj-$(CONFIG_MMC_SDHI) += renesas_sdhi.o
> -renesas_sdhi-$(subst m,y,$(CONFIG_MMC_SDHI_DMA)) += tmio_mmc_dma.o
> +renesas_sdhi-$(subst m,y,$(CONFIG_MMC_SDHI_DMA)) += renesas_sdhi_dma.o
> obj-$(CONFIG_MMC_CB710) += cb710-mmc.o
> obj-$(CONFIG_MMC_VIA_SDMMC) += via-sdmmc.o
> obj-$(CONFIG_SDH_BFIN) += bfin_sdh.o
> diff --git a/drivers/mmc/host/tmio_mmc_dma.c b/drivers/mmc/host/renesas_sdhi_dma.c
> similarity index 100%
> rename from drivers/mmc/host/tmio_mmc_dma.c
> rename to drivers/mmc/host/renesas_sdhi_dma.c
> --
> 2.1.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-22 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 4:01 [PATCH/RFC 0/4] mmc: renesas_sdhi: add R-Car Gen-3 DMA support Simon Horman
2016-06-15 4:01 ` [PATCH/RFC 1/4] mmc: renesas_sdhi: rename sh_mobile_sdhi as renesas_sdhi Simon Horman
2016-06-22 14:11 ` Wolfram Sang
2016-06-15 4:01 ` [PATCH/RFC 2/4] mmc: renesas_sdhi, tmio: make dma more modular Simon Horman
2016-06-22 14:13 ` Wolfram Sang
2016-06-15 4:01 ` [PATCH/RFC 3/4] mmc: renesas_sdhi: rename DMA source file as renesas_sdhi_dma.c Simon Horman
2016-06-22 14:21 ` Wolfram Sang [this message]
2016-06-15 4:01 ` [PATCH/RFC 4/4] mmc: renesas_sdhi: add support for R-Car Gen3 SDHI DMAC Simon Horman
2016-06-27 12:18 ` Wolfram Sang
2016-06-27 12:17 ` [PATCH/RFC 0/4] mmc: renesas_sdhi: add R-Car Gen-3 DMA support Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622142110.GC1645@katana \
--to=wsa@the-dreams.de \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox