public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Doug Anderson <dianders@chromium.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] Documentation: mmc: add description for new no-sd* and no-mmc
Date: Mon, 11 Jul 2016 08:57:35 -0500	[thread overview]
Message-ID: <20160711135735.GA18339@rob-hp-laptop> (raw)
In-Reply-To: <1467359130-11409-4-git-send-email-shawn.lin@rock-chips.com>

On Fri, Jul 01, 2016 at 03:45:30PM +0800, Shawn Lin wrote:
> This patch adds description for no-sd, no-sdio, no-mmc. We
> expect the specific boards adds these in DT to improve
> the initialization. For instance, for a soldered eMMC slot,
> we could skip sending SDIO and SD commands to probe its card
> types as it's always should be the type fo MMC card.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> 
>  Documentation/devicetree/bindings/mmc/mmc.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
> index ecc007a..b2046c6 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
> @@ -49,6 +49,9 @@ Optional properties:
>  - mmc-hs400-enhanced-strobe: eMMC HS400 enhanced strobe mode is supported
>  - dsr: Value the card's (optional) Driver Stage Register (DSR) should be
>    programmed with. Valid range: [0 .. 0xffff].
> +- no-sdio: skip sending sdio cmd during initialization
> +- no-sd: skip sending sd cmd during initialization
> +- no-mmc: skip sending mmc cmd during initialization

I still have issue with the description for these properties and the 
commit msg. They are fine if described as controller limitations as Ulf 
described. If folks want to (ab)use the properties for just skipping 
init, then that's their problem.

Rob

  reply	other threads:[~2016-07-11 13:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-01  7:45 [PATCH 0/3] Expose new mmc caps to DT Shawn Lin
2016-07-01  7:45 ` [PATCH 1/3] mmc: core: Allow hosts to specify non-support for MMC commands Shawn Lin
2016-07-06 16:21   ` Ulf Hansson
2016-07-01  7:45 ` [PATCH 2/3] mmc: core: expose MMC_CAP2_NO_* to dt Shawn Lin
2016-07-01  7:45 ` [PATCH 3/3] Documentation: mmc: add description for new no-sd* and no-mmc Shawn Lin
2016-07-11 13:57   ` Rob Herring [this message]
2016-07-12  1:51     ` Shawn Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160711135735.GA18339@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=jh80.chung@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox