From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v3 3/4] mmc: sh_mobile_sdhi: Add tuning support Date: Wed, 20 Jul 2016 15:24:54 +0900 Message-ID: <20160720062454.GA24635@verge.net.au> References: <1464057797-29951-1-git-send-email-horms+renesas@verge.net.au> <1464057797-29951-4-git-send-email-horms+renesas@verge.net.au> <20160527115933.GD1663@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160527115933.GD1663@katana> Sender: linux-renesas-soc-owner@vger.kernel.org To: Wolfram Sang Cc: Wolfram Sang , Ulf Hansson , Magnus Damm , linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Ai Kyuse List-Id: linux-mmc@vger.kernel.org On Fri, May 27, 2016 at 01:59:34PM +0200, Wolfram Sang wrote: > On Tue, May 24, 2016 at 11:43:16AM +0900, Simon Horman wrote: > > From: Ai Kyuse > > I wonder if you shouldn't take over ownership of this and the previous > patch? You changed quite a lot. Sure, will do. [snip] > > + > > +static unsigned int sh_mobile_sdhi_init_tuning(struct tmio_mmc_host *host) > > +{ > > + if (!(host->mmc->caps & MMC_CAP_UHS_SDR104)) > > + return 0; > > Will the core call us if MMC_CAP_UHS_SDR104 was not set? Empirically, yes, that appears to be the case. For all your other suggestions: thanks, I will update things as you suggest.