* [PATCH 0/2] mmc: tmio: minor SDIO updates
@ 2016-11-13 14:29 Wolfram Sang
2016-11-13 14:29 ` [PATCH 1/2] mmc: tmio: fix wrong bitmask for SDIO irqs Wolfram Sang
2016-11-13 14:29 ` [PATCH 2/2] mmc: tmio: remove SDIO from TODO list Wolfram Sang
0 siblings, 2 replies; 7+ messages in thread
From: Wolfram Sang @ 2016-11-13 14:29 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-renesas-soc, Simon Horman, Wolfram Sang
Here are two small fixes I found while evaluating SDIO with UHS.
Wolfram Sang (2):
mmc: tmio: fix wrong bitmask for SDIO irqs
mmc: tmio: remove SDIO from TODO list
drivers/mmc/host/tmio_mmc_pio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] mmc: tmio: fix wrong bitmask for SDIO irqs
2016-11-13 14:29 [PATCH 0/2] mmc: tmio: minor SDIO updates Wolfram Sang
@ 2016-11-13 14:29 ` Wolfram Sang
2016-11-14 11:24 ` Simon Horman
2016-11-18 14:29 ` Ulf Hansson
2016-11-13 14:29 ` [PATCH 2/2] mmc: tmio: remove SDIO from TODO list Wolfram Sang
1 sibling, 2 replies; 7+ messages in thread
From: Wolfram Sang @ 2016-11-13 14:29 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-renesas-soc, Simon Horman, Wolfram Sang
Commit 7729c7a232a953 ("mmc: tmio: Provide separate interrupt handlers")
refactored the sdio irq handler and wrongly used the mask for SD irqs,
not for SDIO irqs. This doesn't really matter in practice because both
values keep the only interrupt we are interested in. But still, this is
wrong and wants to be fixed.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/tmio_mmc_pio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
index dbc3cb14f3321b..2b04e6e87192c7 100644
--- a/drivers/mmc/host/tmio_mmc_pio.c
+++ b/drivers/mmc/host/tmio_mmc_pio.c
@@ -741,7 +741,7 @@ static void tmio_mmc_sdio_irq(int irq, void *devid)
return;
status = sd_ctrl_read16(host, CTL_SDIO_STATUS);
- ireg = status & TMIO_SDIO_MASK_ALL & ~host->sdcard_irq_mask;
+ ireg = status & TMIO_SDIO_MASK_ALL & ~host->sdio_irq_mask;
sdio_status = status & ~TMIO_SDIO_MASK_ALL;
if (pdata->flags & TMIO_MMC_SDIO_STATUS_QUIRK)
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] mmc: tmio: fix wrong bitmask for SDIO irqs
2016-11-13 14:29 ` [PATCH 1/2] mmc: tmio: fix wrong bitmask for SDIO irqs Wolfram Sang
@ 2016-11-14 11:24 ` Simon Horman
2016-11-18 14:29 ` Ulf Hansson
1 sibling, 0 replies; 7+ messages in thread
From: Simon Horman @ 2016-11-14 11:24 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, linux-renesas-soc
On Sun, Nov 13, 2016 at 03:29:11PM +0100, Wolfram Sang wrote:
> Commit 7729c7a232a953 ("mmc: tmio: Provide separate interrupt handlers")
> refactored the sdio irq handler and wrongly used the mask for SD irqs,
> not for SDIO irqs. This doesn't really matter in practice because both
> values keep the only interrupt we are interested in. But still, this is
> wrong and wants to be fixed.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/mmc/host/tmio_mmc_pio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
> index dbc3cb14f3321b..2b04e6e87192c7 100644
> --- a/drivers/mmc/host/tmio_mmc_pio.c
> +++ b/drivers/mmc/host/tmio_mmc_pio.c
> @@ -741,7 +741,7 @@ static void tmio_mmc_sdio_irq(int irq, void *devid)
> return;
>
> status = sd_ctrl_read16(host, CTL_SDIO_STATUS);
> - ireg = status & TMIO_SDIO_MASK_ALL & ~host->sdcard_irq_mask;
> + ireg = status & TMIO_SDIO_MASK_ALL & ~host->sdio_irq_mask;
>
> sdio_status = status & ~TMIO_SDIO_MASK_ALL;
> if (pdata->flags & TMIO_MMC_SDIO_STATUS_QUIRK)
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] mmc: tmio: fix wrong bitmask for SDIO irqs
2016-11-13 14:29 ` [PATCH 1/2] mmc: tmio: fix wrong bitmask for SDIO irqs Wolfram Sang
2016-11-14 11:24 ` Simon Horman
@ 2016-11-18 14:29 ` Ulf Hansson
1 sibling, 0 replies; 7+ messages in thread
From: Ulf Hansson @ 2016-11-18 14:29 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, Linux-Renesas, Simon Horman
On 13 November 2016 at 15:29, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Commit 7729c7a232a953 ("mmc: tmio: Provide separate interrupt handlers")
> refactored the sdio irq handler and wrongly used the mask for SD irqs,
> not for SDIO irqs. This doesn't really matter in practice because both
> values keep the only interrupt we are interested in. But still, this is
> wrong and wants to be fixed.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/tmio_mmc_pio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
> index dbc3cb14f3321b..2b04e6e87192c7 100644
> --- a/drivers/mmc/host/tmio_mmc_pio.c
> +++ b/drivers/mmc/host/tmio_mmc_pio.c
> @@ -741,7 +741,7 @@ static void tmio_mmc_sdio_irq(int irq, void *devid)
> return;
>
> status = sd_ctrl_read16(host, CTL_SDIO_STATUS);
> - ireg = status & TMIO_SDIO_MASK_ALL & ~host->sdcard_irq_mask;
> + ireg = status & TMIO_SDIO_MASK_ALL & ~host->sdio_irq_mask;
>
> sdio_status = status & ~TMIO_SDIO_MASK_ALL;
> if (pdata->flags & TMIO_MMC_SDIO_STATUS_QUIRK)
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] mmc: tmio: remove SDIO from TODO list
2016-11-13 14:29 [PATCH 0/2] mmc: tmio: minor SDIO updates Wolfram Sang
2016-11-13 14:29 ` [PATCH 1/2] mmc: tmio: fix wrong bitmask for SDIO irqs Wolfram Sang
@ 2016-11-13 14:29 ` Wolfram Sang
2016-11-14 11:25 ` Simon Horman
2016-11-18 14:29 ` Ulf Hansson
1 sibling, 2 replies; 7+ messages in thread
From: Wolfram Sang @ 2016-11-13 14:29 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-renesas-soc, Simon Horman, Wolfram Sang
We surely have SDIO support by now :)
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/tmio_mmc_pio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
index 2b04e6e87192c7..87fea67a743674 100644
--- a/drivers/mmc/host/tmio_mmc_pio.c
+++ b/drivers/mmc/host/tmio_mmc_pio.c
@@ -22,7 +22,6 @@
* TODO:
* Investigate using a workqueue for PIO transfers
* Eliminate FIXMEs
- * SDIO support
* Better Power management
* Handle MMC errors better
* double buffer support
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] mmc: tmio: remove SDIO from TODO list
2016-11-13 14:29 ` [PATCH 2/2] mmc: tmio: remove SDIO from TODO list Wolfram Sang
@ 2016-11-14 11:25 ` Simon Horman
2016-11-18 14:29 ` Ulf Hansson
1 sibling, 0 replies; 7+ messages in thread
From: Simon Horman @ 2016-11-14 11:25 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, linux-renesas-soc
On Sun, Nov 13, 2016 at 03:29:12PM +0100, Wolfram Sang wrote:
> We surely have SDIO support by now :)
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] mmc: tmio: remove SDIO from TODO list
2016-11-13 14:29 ` [PATCH 2/2] mmc: tmio: remove SDIO from TODO list Wolfram Sang
2016-11-14 11:25 ` Simon Horman
@ 2016-11-18 14:29 ` Ulf Hansson
1 sibling, 0 replies; 7+ messages in thread
From: Ulf Hansson @ 2016-11-18 14:29 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, Linux-Renesas, Simon Horman
On 13 November 2016 at 15:29, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We surely have SDIO support by now :)
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/tmio_mmc_pio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
> index 2b04e6e87192c7..87fea67a743674 100644
> --- a/drivers/mmc/host/tmio_mmc_pio.c
> +++ b/drivers/mmc/host/tmio_mmc_pio.c
> @@ -22,7 +22,6 @@
> * TODO:
> * Investigate using a workqueue for PIO transfers
> * Eliminate FIXMEs
> - * SDIO support
> * Better Power management
> * Handle MMC errors better
> * double buffer support
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-11-18 14:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-13 14:29 [PATCH 0/2] mmc: tmio: minor SDIO updates Wolfram Sang
2016-11-13 14:29 ` [PATCH 1/2] mmc: tmio: fix wrong bitmask for SDIO irqs Wolfram Sang
2016-11-14 11:24 ` Simon Horman
2016-11-18 14:29 ` Ulf Hansson
2016-11-13 14:29 ` [PATCH 2/2] mmc: tmio: remove SDIO from TODO list Wolfram Sang
2016-11-14 11:25 ` Simon Horman
2016-11-18 14:29 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).