From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH 1/2] mmc: tmio: fix wrong bitmask for SDIO irqs Date: Mon, 14 Nov 2016 12:24:53 +0100 Message-ID: <20161114112452.GA13611@verge.net.au> References: <20161113142912.4041-1-wsa+renesas@sang-engineering.com> <20161113142912.4041-2-wsa+renesas@sang-engineering.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161113142912.4041-2-wsa+renesas@sang-engineering.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: Wolfram Sang Cc: linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org List-Id: linux-mmc@vger.kernel.org On Sun, Nov 13, 2016 at 03:29:11PM +0100, Wolfram Sang wrote: > Commit 7729c7a232a953 ("mmc: tmio: Provide separate interrupt handlers") > refactored the sdio irq handler and wrongly used the mask for SD irqs, > not for SDIO irqs. This doesn't really matter in practice because both > values keep the only interrupt we are interested in. But still, this is > wrong and wants to be fixed. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > drivers/mmc/host/tmio_mmc_pio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c > index dbc3cb14f3321b..2b04e6e87192c7 100644 > --- a/drivers/mmc/host/tmio_mmc_pio.c > +++ b/drivers/mmc/host/tmio_mmc_pio.c > @@ -741,7 +741,7 @@ static void tmio_mmc_sdio_irq(int irq, void *devid) > return; > > status = sd_ctrl_read16(host, CTL_SDIO_STATUS); > - ireg = status & TMIO_SDIO_MASK_ALL & ~host->sdcard_irq_mask; > + ireg = status & TMIO_SDIO_MASK_ALL & ~host->sdio_irq_mask; > > sdio_status = status & ~TMIO_SDIO_MASK_ALL; > if (pdata->flags & TMIO_MMC_SDIO_STATUS_QUIRK) > -- > 2.9.3 >