Re: [PATCH v4 11/12] arm64: dts: marvell: add sdhci support for Armada 7K/8K

Russell King - ARM Linux
2016-12-22T11:24:16Z

On Tue, Dec 13, 2016 at 06:48:40PM +0100, Gregory CLEMENT wrote:
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> index 7b6136182ad0..181e8c5de3bf 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> @@ -229,6 +229,15 @@
>
> };
>
> + ap_sdhci0: sdhci@6e0000 {
> + compatible = "marvell,armada-7000-sdhci";
> + reg = <0x6e0000 0x300>;
> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "core";
> + clocks = <&cpm_syscon0 1 4>;
> + status = "disabled";
> + };
> +
> ap_syscon: system-controller@6f4000 {
> compatible = "marvell,ap806-system-controller",
> "syscon";
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> index e5e3ed678b6f..035b2b2fc9ca 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
> @@ -164,6 +164,16 @@
> clocks = <&cpm_syscon0 1 21>;
> status = "disabled";
> };
> +
> + cpm_sdhci0: sdhci@780000 {
> + compatible = "marvell,armada-7000-sdhci";
> + reg = <0x780000 0x300>;
> + interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "core";
> + clocks = <&cpm_syscon0 1 4>;
> + status = "disabled";
> + };
> +

One other point - aren't the SDHCI interfaces dma-coherent on the AP806
and CP110?

--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.