Re: [PATCH v4 11/12] arm64: dts: marvell: add sdhci support for Armada 7K/8K

Thomas Petazzoni
2016-12-22T10:47:51Z

Hello,

On Thu, 22 Dec 2016 10:45:02 +0000, Russell King - ARM Linux wrote:
> On Tue, Dec 13, 2016 at 06:48:40PM +0100, Gregory CLEMENT wrote:
> > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> > index 7b6136182ad0..181e8c5de3bf 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> > @@ -229,6 +229,15 @@
> >
> > };
> >
> > + ap_sdhci0: sdhci@6e0000 {
> > + compatible = "marvell,armada-7000-sdhci";
> > + reg = <0x6e0000 0x300>;
> > + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> > + clock-names = "core";
> > + clocks = <&cpm_syscon0 1 4>;
>
> This seems to be the wrong clock - how can the AP SDHCI core be connected
> to the CPM syscon (which is on a different die.)

Agreed. This cannot be the right clock.

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering