From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Yehuda Yitschak <yehuday@marvell.com>,
Marcin Wojtas <mw@semihalf.com>,
Jason Cooper <jason@lakedaemon.net>,
Hanna Hawa <hannah@marvell.com>,
Kostya Porotchkin <kostap@marvell.com>,
Nadav Haklai <nadavh@marvell.com>, Ziji Hu <huziji@marvell.com>,
Jimmy Xu <zmxu@marvell.com>, Doug Jones <dougj@marvell.com>,
Ryan Gao <ygao@marvell.com>, Jisheng Zhang <jszhang@marvell.com>,
Victor Gu <xigu@marvell.com>, "Wei(SOCP) Liu" <liuw@marvell.com>,
Wilson Ding <dingwei@marvell.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v4 11/12] arm64: dts: marvell: add sdhci support for Armada 7K/8K
Date: Thu, 22 Dec 2016 11:47:47 +0100 [thread overview]
Message-ID: <20161222114747.734faa50@free-electrons.com> (raw)
In-Reply-To: <20161222104502.GV14217@n2100.armlinux.org.uk>
Hello,
On Thu, 22 Dec 2016 10:45:02 +0000, Russell King - ARM Linux wrote:
> On Tue, Dec 13, 2016 at 06:48:40PM +0100, Gregory CLEMENT wrote:
> > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> > index 7b6136182ad0..181e8c5de3bf 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> > @@ -229,6 +229,15 @@
> >
> > };
> >
> > + ap_sdhci0: sdhci@6e0000 {
> > + compatible = "marvell,armada-7000-sdhci";
> > + reg = <0x6e0000 0x300>;
> > + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> > + clock-names = "core";
> > + clocks = <&cpm_syscon0 1 4>;
>
> This seems to be the wrong clock - how can the AP SDHCI core be connected
> to the CPM syscon (which is on a different die.)
Agreed. This cannot be the right clock.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-12-22 10:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 17:48 [PATCH v4 00/12] mmc: Add support to Marvell Xenon SD Host Controller Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 01/12] mmc: sdhci: Export sdhci_set_ios() from sdhci.c Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 02/12] mmc: sdhci: Export sdhci_start_signal_voltage_switch() in sdhci.c Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 03/12] mmc: sdhci: Export sdhci_execute_tuning() " Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 04/12] mmc: sdhci: Export sdhci_enable_sdio_irq() from sdhci.c Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 05/12] MAINTAINERS: add entry for Marvell Xenon MMC Host Controller drivers Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 06/12] dt: bindings: Add bindings for Marvell Xenon SD Host Controller Gregory CLEMENT
2016-12-22 11:18 ` Russell King - ARM Linux
2016-12-22 12:47 ` Ziji Hu
2016-12-13 17:48 ` [PATCH v4 07/12] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality Gregory CLEMENT
2017-01-04 7:26 ` Adrian Hunter
2017-01-04 8:51 ` Ziji Hu
2017-01-04 9:08 ` Adrian Hunter
2016-12-13 17:48 ` [PATCH v4 08/12] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 09/12] mmc: sdhci-xenon: Add SOC PHY PAD voltage control Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 10/12] arm64: dts: marvell: add eMMC support for Armada 37xx Gregory CLEMENT
2016-12-13 17:48 ` [PATCH v4 11/12] arm64: dts: marvell: add sdhci support for Armada 7K/8K Gregory CLEMENT
2016-12-22 10:45 ` Russell King - ARM Linux
2016-12-22 10:47 ` Thomas Petazzoni [this message]
2016-12-22 10:47 ` Russell King - ARM Linux
2016-12-22 11:21 ` Russell King - ARM Linux
2016-12-13 17:48 ` [PATCH v4 12/12] arm64: configs: enable SDHCI driver for Xenon Gregory CLEMENT
[not found] ` <CAPv3WKeE_2gMn12MXraoUmDEJhi307mGuc4BgDYpethKNsMqRQ@mail.gmail.com>
2016-12-14 19:02 ` [PATCH v4 00/12] mmc: Add support to Marvell Xenon SD Host Controller Marcin Wojtas
2016-12-22 11:25 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161222114747.734faa50@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=adrian.hunter@intel.com \
--cc=andrew@lunn.ch \
--cc=dingwei@marvell.com \
--cc=dougj@marvell.com \
--cc=gregory.clement@free-electrons.com \
--cc=hannah@marvell.com \
--cc=huziji@marvell.com \
--cc=jason@lakedaemon.net \
--cc=jszhang@marvell.com \
--cc=kostap@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liuw@marvell.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=xigu@marvell.com \
--cc=yehuday@marvell.com \
--cc=ygao@marvell.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox