linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Simon Horman <horms+renesas@verge.net.au>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Ai Kyuse <ai.kyuse.uw@renesas.com>
Subject: Re: [PATCH v8 6/6] mmc: sh_mobile_sdhi: Add tuning support
Date: Tue, 10 Jan 2017 23:30:43 +0100	[thread overview]
Message-ID: <20170110223043.GA2710@katana> (raw)
In-Reply-To: <20170110210848.GA25542@bigcity.dyn.berto.se>

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]


> Oddly enough the error are only printed when I insert the SD card in the 
> mmc0 slot. I can insert/eject the card multiple times in mmc1 and no 
> error but the first insertion in mmc0 and boom. Only difference I can 
> see are the clock speed between mmc0 and mmc1.

Can you try this patch?

From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date: Sun, 13 Nov 2016 11:10:09 +0100
Subject: [PATCH] pinctrl: pfc: r8a7795: WIP: hardcode TDSEL value

Otherwise, AC-180M won't get probed with SDR50 and EMMY-W1 has more
tuning errors with SDR104.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 3f58bfd676ce94..3e3f7585efe8b3 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -5416,6 +5416,9 @@ static int r8a7795_pinmux_init(struct sh_pfc *pfc)
 		pr_info("%s: R-Car H3 >= ES2.0\n", __func__);
 		// FIXME Fixup r8a7795_pinmux_info for ES2.0
 	}
+
+#define TDSEL 0xe60603c0
+	sh_pfc_write_reg(pfc, TDSEL, 32, 0xc3);
 	return 0;
 }
 
-- 
2.10.2



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2017-01-10 22:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 14:15 [PATCH v8 0/6] UHS-I SDR-104 support for sh_mobile_sdhi Simon Horman
2016-11-03 14:15 ` [PATCH v8 1/6] mmc: core: Add helper to see if a host can be retuned Simon Horman
2016-11-03 14:16 ` [PATCH v8 2/6] mmc: tmio: enhance illegal sequence handling Simon Horman
2016-11-03 14:16 ` [PATCH v8 3/6] mmc: tmio: document mandatory and optional callbacks Simon Horman
2016-11-03 14:16 ` [PATCH v8 4/6] mmc: tmio: Add hw reset support Simon Horman
2016-11-03 14:16 ` [PATCH v8 5/6] mmc: tmio: Add tuning support Simon Horman
2016-11-03 14:16 ` [PATCH v8 6/6] mmc: sh_mobile_sdhi: " Simon Horman
2017-01-10 21:08   ` Niklas Söderlund
2017-01-10 22:30     ` Wolfram Sang [this message]
2017-01-11  8:35       ` Niklas Söderlund
2017-01-11  8:42         ` Geert Uytterhoeven
2017-01-11  9:17           ` Niklas Söderlund
2017-01-11 15:05         ` Wolfram Sang
2017-01-11 15:57           ` Niklas Söderlund
2017-01-11 15:59             ` Geert Uytterhoeven
2017-01-11 17:34               ` Wolfram Sang
2017-01-12 11:17                 ` Niklas Söderlund
2017-01-12 11:23                   ` Geert Uytterhoeven
2017-01-12 13:03                     ` Wolfram Sang
2017-01-17 11:29                       ` Niklas Söderlund
2017-01-23 11:16     ` Wolfram Sang
2017-01-31 20:56       ` Niklas Söderlund
2017-01-26  9:58     ` Simon Horman
2016-11-10 11:45 ` [PATCH v8 0/6] UHS-I SDR-104 support for sh_mobile_sdhi Wolfram Sang
2016-11-10 22:21   ` Ulf Hansson
2016-11-11  7:20     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110223043.GA2710@katana \
    --to=wsa@the-dreams.de \
    --cc=ai.kyuse.uw@renesas.com \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).