From: Wolfram Sang <wsa@the-dreams.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Simon Horman <horms+renesas@verge.net.au>
Subject: Re: [PATCH] mmc: tmio: Remove redundant check of mmc->slot.cd_irq
Date: Tue, 17 Jan 2017 21:53:47 +0100 [thread overview]
Message-ID: <20170117205347.7kihefzza5lf54fy@ninjato> (raw)
In-Reply-To: <1484061052-25334-1-git-send-email-ulf.hansson@linaro.org>
On Tue, Jan 10, 2017 at 04:10:52PM +0100, Ulf Hansson wrote:
> To validate whether native hotplug needs to be used, the tmio driver checks
> whether the mmc->slot.cd_irq has been successfully assigned.
>
> This check is redundant at its current place in tmio_mmc_host_probe(), as
> the mmc core assigns mmc->slot.cd_irq a valid value first when
> mmc_gpiod_request_cd_irq() is called. Therefore, let's just remove the
> check for now, as that also removes a layering violation of the tmio driver
> accessing core specific data via ->slot.cd_irq.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Agreed. This is a layering violation and can be safely removed since it
is a no-op currently.
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Besides card eject still works on my M3-W. I will test on my H2 tomorrow
or the day after that.
Thanks,
Wolfram
prev parent reply other threads:[~2017-01-17 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 15:10 [PATCH] mmc: tmio: Remove redundant check of mmc->slot.cd_irq Ulf Hansson
2017-01-17 15:08 ` Ulf Hansson
2017-01-17 20:53 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117205347.7kihefzza5lf54fy@ninjato \
--to=wsa@the-dreams.de \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox