From: Simon Horman <horms@verge.net.au>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Ai Kyuse <ai.kyuse.uw@renesas.com>
Subject: Re: [PATCH v8 6/6] mmc: sh_mobile_sdhi: Add tuning support
Date: Thu, 26 Jan 2017 10:58:45 +0100 [thread overview]
Message-ID: <20170126095845.GB21851@verge.net.au> (raw)
In-Reply-To: <20170110210848.GA25542@bigcity.dyn.berto.se>
On Tue, Jan 10, 2017 at 10:08:48PM +0100, Niklas Söderlund wrote:
> Hi Simon,
>
> I started to se errors when I was testing DMAC+IPMMU patches on top of
> v4.10-rc1 on Koelsch.
There has been some discussion in this thread already. I would like to
provide some more information in case it is useful.
The 3.5.0 BSP appears to contain several that may be relevant to this
discussion:
383c4437846d mmc: sh_mobile_sdhi: Add detecting a change point of data to SCC tuning
1823812e0937 mmc: tmio: Add detecting a change point of data to SCC tunin
03935e9182d9 mmc: tmio: Fix tuning flow
c711db03349c mmc: sh_mobile_sdhi: Fix sampling clock position selecting
2838a2ff8ca7 mmc: tmio: fix soft lockup on CMD12 for R-Car SDHI
Of these, so far I have looked into "mmc: tmio: Fix tuning flow".
It seems to do several things:
- Ensure tuning initialisation is called for each tuning procedure:
this seems a correct fix for a bug added by me
- Do not terminate tuning on error:
this is not my reading of the documentation but may well be correct
- Reset more:
I am least sure about this as it does not seem to have any explanation
in the changelog
next prev parent reply other threads:[~2017-01-26 9:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 14:15 [PATCH v8 0/6] UHS-I SDR-104 support for sh_mobile_sdhi Simon Horman
2016-11-03 14:15 ` [PATCH v8 1/6] mmc: core: Add helper to see if a host can be retuned Simon Horman
2016-11-03 14:16 ` [PATCH v8 2/6] mmc: tmio: enhance illegal sequence handling Simon Horman
2016-11-03 14:16 ` [PATCH v8 3/6] mmc: tmio: document mandatory and optional callbacks Simon Horman
2016-11-03 14:16 ` [PATCH v8 4/6] mmc: tmio: Add hw reset support Simon Horman
2016-11-03 14:16 ` [PATCH v8 5/6] mmc: tmio: Add tuning support Simon Horman
2016-11-03 14:16 ` [PATCH v8 6/6] mmc: sh_mobile_sdhi: " Simon Horman
2017-01-10 21:08 ` Niklas Söderlund
2017-01-10 22:30 ` Wolfram Sang
2017-01-11 8:35 ` Niklas Söderlund
2017-01-11 8:42 ` Geert Uytterhoeven
2017-01-11 9:17 ` Niklas Söderlund
2017-01-11 15:05 ` Wolfram Sang
2017-01-11 15:57 ` Niklas Söderlund
2017-01-11 15:59 ` Geert Uytterhoeven
2017-01-11 17:34 ` Wolfram Sang
2017-01-12 11:17 ` Niklas Söderlund
2017-01-12 11:23 ` Geert Uytterhoeven
2017-01-12 13:03 ` Wolfram Sang
2017-01-17 11:29 ` Niklas Söderlund
2017-01-23 11:16 ` Wolfram Sang
2017-01-31 20:56 ` Niklas Söderlund
2017-01-26 9:58 ` Simon Horman [this message]
2016-11-10 11:45 ` [PATCH v8 0/6] UHS-I SDR-104 support for sh_mobile_sdhi Wolfram Sang
2016-11-10 22:21 ` Ulf Hansson
2016-11-11 7:20 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126095845.GB21851@verge.net.au \
--to=horms@verge.net.au \
--cc=ai.kyuse.uw@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).