From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 06/16] mmc: core: replace waitqueue with worker Date: Tue, 14 Mar 2017 15:43:57 +0100 Message-ID: <20170314144357.GA31043@lst.de> References: <20170209153403.9730-1-linus.walleij@linaro.org> <20170209153403.9730-7-linus.walleij@linaro.org> <00989e26-cdb9-48d7-2e46-ae6ef66e59a7@intel.com> <3fc89f9f-fbcf-113d-3644-b6c9dae003f0@intel.com> <8f1f3d4c-410c-2632-c776-4ced363bdb0d@kernel.dk> <97f2a4ea-0802-9f23-6ac7-b9d6c6afbfcc@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.211]:58587 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751910AbdCNOoA (ORCPT ); Tue, 14 Mar 2017 10:44:00 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Jens Axboe Cc: Adrian Hunter , Linus Walleij , "linux-mmc@vger.kernel.org" , Ulf Hansson , Paolo Valente , Chunyan Zhang , Baolin Wang , linux-block@vger.kernel.org, Christoph Hellwig , Arnd Bergmann On Tue, Mar 14, 2017 at 08:36:26AM -0600, Jens Axboe wrote: > There's one case that doesn't look like it was converted properly, but > that's a mistake. The general insert-and-run cases run inline if we can, > but the direct-issue needs a fixup, see below. Note that blk_mq_try_issue_directly is only called for the multiple hardware queue case, so MMC would not hit it.