Re: [PATCH v12 4/9] mmc: cavium: Work-around hardware bug on cn6xxx and cnf7xxx

Arnd Bergmann
2017-03-21T08:58:24Z

On Mon, Mar 20, 2017 at 9:45 PM, David Daney <ddaney@caviumnetworks.com> wrote:
> On 03/17/2017 07:13 AM, Ulf Hansson wrote:
>> My point is really that we should avoid exporting SoC specific APIs
>> which shall be called from drivers. This is old fashion.
>
>
> Some people find it objectionable to see 1-off architecture specific in-line
> asm in a driver file, but I agree that putting it as close to the user as
> possible makes sense.

The proper solution might be to create an architecture independent interface
for it, what it is that the function does. Can you explain what the purpose
of locking/unlocking the cache line for MMC is? Is this something that
could be done more generally in the dma_map_ops implementation?

Arnd