public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Eddie Cai <eddie.cai.kernel@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Ziyuan Xu <xzy.xu@rock-chips.com>,
	linux-mmc@vger.kernel.org, linux-rockchip@lists.infradead.org,
	amstan@chromium.org, Kevin Mihelich <kevin@archlinuxarm.org>,
	Doug Anderson <dianders@chromium.org>
Subject: Re: [REGRESSION 4.10] dw_mmc: failures on Rockchip rk3288 veyron boards
Date: Thu, 6 Apr 2017 15:04:11 -0700	[thread overview]
Message-ID: <20170406220410.GA5708@google.com> (raw)
In-Reply-To: <6b9a3425-fe3c-0c9a-8d1b-d2d2ac1ec9de@samsung.com>

Hi,

On Thu, Mar 30, 2017 at 02:11:19PM +0900, Jaehoon Chung wrote:
> On 03/30/2017 11:53 AM, Brian Norris wrote:
> > On Thu, Mar 30, 2017 at 10:18:59AM +0800, Eddie Cai wrote:
> >> I test on rk3288 firefly reload with 4.11-rc4. It work fine.
> > 
> > OK, thanks for checking.
> > 
> >>> On Thu, Mar 30, 2017 at 09:32:22AM +0800, Shawn Lin wrote:
> >>>> Hi Brian,
> >>>>
> >>>> On 2017/3/30 9:17, Brian Norris wrote:
> >>>>> Hi all,
> >>>>>
> >>>>> I haven't managed to get as far as a bugfix for this, but I've bisected
> >>>>> some issues seen on v4.10+ with a Chromebook of the Veyron family (Jaq,
> >>>>> in particular). v4.9 works fine.
> > 
> > [...]
> > 
> > By the way, Kevin (CC'd) says he noticed similiar Wifi issues on an
> > Exynos 5800 Peach chromebook, but not on an Exynos 5250 Snow chromebook.	
> > I haven't picked these apart yet to see what the differences and
> > similarities are, but presumably it's not actually a Rockchip-specific
> > bug. Maybe related to the way power sequencing is plumbed for these, for
> > example?
> 
> I'm not sure but if card-detecting is polling, the timing issue could be occurred.

I don't know much about MMC in general, nor about this driver. Any
chance you'd accept reverts of the patches in question though? This is a
huge regression, and there were only a few relevant changes that seem to
have triggered this. I can try to come up with something targeted, but
I'm not going to even try if that'd get rejected up front.

Brian

  reply	other threads:[~2017-04-06 22:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30  1:17 [REGRESSION 4.10] dw_mmc: failures on Rockchip rk3288 veyron boards Brian Norris
     [not found] ` <20170330011709.GA110687-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-03-30  1:32   ` Shawn Lin
2017-03-30  1:42     ` Brian Norris
2017-03-30  2:18       ` Eddie Cai
2017-03-30  2:53         ` Brian Norris
2017-03-30  5:11           ` Jaehoon Chung
2017-04-06 22:04             ` Brian Norris [this message]
2017-04-07  4:59               ` Jaehoon Chung
2017-04-07  6:50               ` Shawn Lin
2017-04-07  7:38                 ` Jaehoon Chung
2017-04-10 23:35 ` Doug Anderson
2017-04-11 10:21   ` Ulf Hansson
2017-04-11 22:57     ` Doug Anderson
2017-04-12  0:54   ` Shawn Lin
2017-04-12 16:12     ` Doug Anderson
2017-04-13  7:17       ` Ulf Hansson
2017-04-13 15:45         ` Doug Anderson
2017-04-13  8:28       ` Shawn Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406220410.GA5708@google.com \
    --to=briannorris@chromium.org \
    --cc=amstan@chromium.org \
    --cc=dianders@chromium.org \
    --cc=eddie.cai.kernel@gmail.com \
    --cc=heiko@sntech.de \
    --cc=jh80.chung@samsung.com \
    --cc=kevin@archlinuxarm.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=xzy.xu@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox