* [PATCH] mmc: vub3000: add missing USB-descriptor endianness conversions
@ 2017-05-12 10:03 Johan Hovold
[not found] ` <20170512100335.1637-1-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2017-05-12 10:03 UTC (permalink / raw)
To: Tony Olech, Ulf Hansson
Cc: linux-mmc-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA, Johan Hovold
Add the missing endianness conversions when printing the USB
device-descriptor idVendor and idProduct fields during probe.
Signed-off-by: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
drivers/mmc/host/vub300.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index c061e7c704be..fbeea1a491a6 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -2107,7 +2107,8 @@ static int vub300_probe(struct usb_interface *interface,
usb_string(udev, udev->descriptor.iSerialNumber, serial_number,
sizeof(serial_number));
dev_info(&udev->dev, "probing VID:PID(%04X:%04X) %s %s %s\n",
- udev->descriptor.idVendor, udev->descriptor.idProduct,
+ le16_to_cpu(udev->descriptor.idVendor),
+ le16_to_cpu(udev->descriptor.idProduct),
manufacturer, product, serial_number);
command_out_urb = usb_alloc_urb(0, GFP_KERNEL);
if (!command_out_urb) {
--
2.13.0
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: vub3000: add missing USB-descriptor endianness conversions
[not found] ` <20170512100335.1637-1-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2017-05-15 10:51 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2017-05-15 10:51 UTC (permalink / raw)
To: Johan Hovold
Cc: Tony Olech, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux USB List
On 12 May 2017 at 12:03, Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> Add the missing endianness conversions when printing the USB
> device-descriptor idVendor and idProduct fields during probe.
>
> Signed-off-by: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/vub300.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> index c061e7c704be..fbeea1a491a6 100644
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -2107,7 +2107,8 @@ static int vub300_probe(struct usb_interface *interface,
> usb_string(udev, udev->descriptor.iSerialNumber, serial_number,
> sizeof(serial_number));
> dev_info(&udev->dev, "probing VID:PID(%04X:%04X) %s %s %s\n",
> - udev->descriptor.idVendor, udev->descriptor.idProduct,
> + le16_to_cpu(udev->descriptor.idVendor),
> + le16_to_cpu(udev->descriptor.idProduct),
> manufacturer, product, serial_number);
> command_out_urb = usb_alloc_urb(0, GFP_KERNEL);
> if (!command_out_urb) {
> --
> 2.13.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-15 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-12 10:03 [PATCH] mmc: vub3000: add missing USB-descriptor endianness conversions Johan Hovold
[not found] ` <20170512100335.1637-1-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-05-15 10:51 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox