From: Jan Glauber <jglauber@cavium.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: David Daney <david.daney@cavium.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
"Steven J . Hill" <Steven.Hill@cavium.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Glauber <jglauber@cavium.com>
Subject: [PATCH 5/5] mmc: cavium: Fix probing race with regulator
Date: Tue, 16 May 2017 11:36:55 +0200 [thread overview]
Message-ID: <20170516093655.17746-6-jglauber@cavium.com> (raw)
In-Reply-To: <20170516093655.17746-1-jglauber@cavium.com>
If the regulator probing is not yet finished this driver
might catch a -EPROBE_DEFER. Returning after this condition
did not remove the created platform device. On a repeated
call to the probe function the of_platform_device_create
fails.
Calling of_platform_device_destroy after EPROBE_DEFER resolves
this bug.
Signed-off-by: Jan Glauber <jglauber@cavium.com>
---
drivers/mmc/host/cavium-thunderx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/cavium-thunderx.c b/drivers/mmc/host/cavium-thunderx.c
index fe3d772..257535e 100644
--- a/drivers/mmc/host/cavium-thunderx.c
+++ b/drivers/mmc/host/cavium-thunderx.c
@@ -137,8 +137,10 @@ static int thunder_mmc_probe(struct pci_dev *pdev,
continue;
ret = cvm_mmc_of_slot_probe(&host->slot_pdev[i]->dev, host);
- if (ret)
+ if (ret) {
+ of_platform_device_destroy(&host->slot_pdev[i]->dev, NULL);
goto error;
+ }
}
i++;
}
--
2.9.0.rc0.21.g7777322
next prev parent reply other threads:[~2017-05-16 9:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 9:36 [PATCH 0/5] mmc: cavium: bug fixes for 4.12 Jan Glauber
2017-05-16 9:36 ` [PATCH 1/5] mmc: cavium-octeon: Fix interrupt enable code Jan Glauber
2017-05-16 9:36 ` [PATCH 2/5] mmc: cavium-octeon: Use proper GPIO name for power control Jan Glauber
2017-05-16 9:36 ` [PATCH 3/5] mmc: cavium: Prevent crash with incomplete DT Jan Glauber
2017-05-19 7:16 ` Ulf Hansson
2017-05-16 9:36 ` [PATCH 4/5] of/platform: Make of_platform_device_destroy globally visible Jan Glauber
2017-05-16 9:36 ` Jan Glauber [this message]
2017-05-16 13:07 ` [PATCH 5/5] mmc: cavium: Fix probing race with regulator Rob Herring
2017-05-16 13:38 ` Jan Glauber
2017-05-16 14:37 ` Rob Herring
2017-05-16 16:50 ` David Daney
2017-05-17 13:41 ` Jan Glauber
2017-05-18 9:39 ` Jan Glauber
2017-05-18 12:55 ` Rob Herring
2017-05-19 8:30 ` [PATCH 0/5] mmc: cavium: bug fixes for 4.12 Ulf Hansson
2017-05-19 10:42 ` Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516093655.17746-6-jglauber@cavium.com \
--to=jglauber@cavium.com \
--cc=Steven.Hill@cavium.com \
--cc=david.daney@cavium.com \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox