Re: [PATCH 4/5] mmc: tmio: improve checkpatch cleanness

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

On Tue, May 30, 2017 at 02:50:53PM +0200, Simon Horman wrote:
> Trivial updates to improve checkpatch cleanness.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Wow, all of them! When I reviewed your DMA refactoring patches, I meant
to fix only the whitespace issues which were affecting your patches. But
okay, it is a good timing to fix all of those, because of the said DMA
refactoring work, the BSP patches won't fit anymore anyhow, so upporting
them will not become significantly harder.

And while I don't agree with all of checkpatch suggestions, this patch
increases code readability for sure. I guess, what I am saying is:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

and

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

I moved big files around two SD cards attached simultaneously to two
card slots on my Renesas Lager (H2).

> -	if (host->chan_tx && (data->flags & MMC_DATA_WRITE) && !host->force_pio) {
> +	if (host->chan_tx && (data->flags & MMC_DATA_WRITE) &&
> +	    !host->force_pio) {
>  		u32 status = sd_ctrl_read16_and_16_as_32(host, CTL_STATUS);
>  		bool done = false;

Let me give just one example where I think the 80 char limit doesn't
help readability. But no need to fix IMO; as I said, most of the stuff
is really helpful.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]