From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 4/5] mmc: tmio: improve checkpatch cleanness
Date: Wed, 31 May 2017 22:02:35 +0200 [thread overview]
Message-ID: <20170531200235.GG22266@verge.net.au> (raw)
In-Reply-To: <1496148654-20386-5-git-send-email-horms+renesas@verge.net.au>
On Tue, May 30, 2017 at 02:50:53PM +0200, Simon Horman wrote:
> Trivial updates to improve checkpatch cleanness.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
...
> diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
> index 70516abd50a1..07905c05f356 100644
> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> @@ -127,16 +127,17 @@ static int tmio_mmc_next_sg(struct tmio_mmc_host *host)
>
> #define STATUS_TO_TEXT(a, status, i) \
> do { \
> - if (status & TMIO_STAT_##a) { \
> - if (i++) \
> - printk(" | "); \
> - printk(#a); \
> + if ((status) & TMIO_STAT_##a) { \
> + if ((i)++) \
> + printk(KERN_DEBUG, " | "); \
> + printk(KERN_DEBUG, #a); \
Ooops, 0-day tells me that there should not be a comma after KERN_DEBUG.
I'll fix that in v2.
...
next prev parent reply other threads:[~2017-05-31 20:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 12:50 [PATCH 0/5] mmc: tmio, renesas-sdhi: cleanups Simon Horman
2017-05-30 12:50 ` [PATCH 1/5] MAINTAINERS: Update files for TMIO/SDHI MMC driver Simon Horman
2017-05-30 19:31 ` Wolfram Sang
2017-05-30 12:50 ` [PATCH 2/5] mmc: tmio: use EXPORT_SYMBOL_GPL Simon Horman
2017-05-30 19:35 ` Wolfram Sang
2017-05-30 12:50 ` [PATCH 3/5] mmc: tmio, renesas-sdhi: update Renesas related copyrights Simon Horman
2017-05-30 19:37 ` Wolfram Sang
2017-05-30 12:50 ` [PATCH 4/5] mmc: tmio: improve checkpatch cleanness Simon Horman
2017-05-30 19:58 ` Wolfram Sang
2017-05-31 19:58 ` Simon Horman
2017-05-31 20:02 ` Simon Horman [this message]
2017-05-30 12:50 ` [PATCH 5/5] mmc: renesas-sdhi: " Simon Horman
2017-05-30 19:57 ` Wolfram Sang
2017-06-08 13:52 ` [PATCH 0/5] mmc: tmio, renesas-sdhi: cleanups Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531200235.GG22266@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox