Re: [PATCH/RFC 4/5] mmc: renesas_sdhi: add support for R-Car Gen3 SDHI DMAC

[Simon Horman <horms@verge.net.au>]

On Fri, Jun 09, 2017 at 09:39:49AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Jun 8, 2017 at 3:13 PM, Simon Horman <horms+renesas@verge.net.au> wrote:
> > R-Car Gen3 has a dedicated DMA controller for SDHI module. Since
> > the DMAC is in a part of SDHI module and is not suitable as dmaengine,
> 
> the DMAC is part of the SDHI module?
> 
> > this patch adds a different code as tmio_mmc_dma_gen3.c.
> 
> adds different code?
> 
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -575,10 +575,27 @@ config MMC_SDHI
> >         depends on SUPERH || ARM || ARM64
> >         depends on SUPERH || ARCH_RENESAS || COMPILE_TEST
> >         select MMC_TMIO_CORE
> > +       select MMC_SDHI_SYS_DMAC if (SUPERH || ARM)
> > +       select MMC_SDHI_INTERNAL_DMAC if ARM64
> >         help
> >           This provides support for the SDHI SD/SDIO controller found in
> >           Renesas SuperH, ARM and ARM64 based SoCs
> >
> > +config MMC_SDHI_SYS_DMAC
> > +       tristate "DMA support use of SYS DMAC with SDHI SD/SDIO controller"
> 
> DMA support for SYS_DMAC?

How about this?

config MMC_SDHI_SYS_DMAC
	tristate "DMA for SDHI SD/SDIO controllers using SYS-DMAC"
	...
	help
	   This provides DMA support for the SDHI SD/SDIO controllers
	   using SYS-DMAC via DMA Engine. This supports the controllers
	   found in SuperH and Renesas ARM based SoCs.

config MMC_SDHI_INTERNAL_DMAC
	tristate "DMA for SDHI SD/SDIO controllers using on-chip bus mastering"
	...
	help
	   This provides DMA support for the SDHI SD/SDIO controllers
	   using on-chip bus mastering. This supports the controllers
	   found in arm64 based SoCs.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>