[PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static

[PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

The guid intel_dsm_guid does not need to be in global scope, so make
it static.

Cleans up sparse warning:
"symbol 'intel_dsm_guid' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/mmc/host/sdhci-pci-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 3c02c5b394d6..f1d8385d91f0 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -404,7 +404,7 @@ struct intel_host {
 	bool	d3_retune;
 };
 
-const guid_t intel_dsm_guid =
+static const guid_t intel_dsm_guid =
 	GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
 		  0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
 
-- 
2.11.0

Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static

[Adrian Hunter]

On 13/06/17 16:14, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The guid intel_dsm_guid does not need to be in global scope, so make
> it static.
> 
> Cleans up sparse warning:
> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

But this patch is dependent on the guid changes which are not in the mmc
tree.  It's in a tree of Christoph's I think.

> ---
>  drivers/mmc/host/sdhci-pci-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 3c02c5b394d6..f1d8385d91f0 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -404,7 +404,7 @@ struct intel_host {
>  	bool	d3_retune;
>  };
>  
> -const guid_t intel_dsm_guid =
> +static const guid_t intel_dsm_guid =
>  	GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
>  		  0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>  
> 

Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static

[Ulf Hansson]

On 14 June 2017 at 08:08, Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 13/06/17 16:14, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The guid intel_dsm_guid does not need to be in global scope, so make
>> it static.
>>
>> Cleans up sparse warning:
>> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> But this patch is dependent on the guid changes which are not in the mmc
> tree.  It's in a tree of Christoph's I think.

Right, in such case maybe Christoph can pick this up?

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

>
>> ---
>>  drivers/mmc/host/sdhci-pci-core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
>> index 3c02c5b394d6..f1d8385d91f0 100644
>> --- a/drivers/mmc/host/sdhci-pci-core.c
>> +++ b/drivers/mmc/host/sdhci-pci-core.c
>> @@ -404,7 +404,7 @@ struct intel_host {
>>       bool    d3_retune;
>>  };
>>
>> -const guid_t intel_dsm_guid =
>> +static const guid_t intel_dsm_guid =
>>       GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
>>                 0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static

[Christoph Hellwig]

Please resend any patches I should pick up directly to me, thanks.