From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH mmc/next v2 2/4] mmc: tmio, renesas-sdhi: add complete to DMA ops
Date: Mon, 19 Jun 2017 13:58:39 +0200 [thread overview]
Message-ID: <20170619115839.GC20088@verge.net.au> (raw)
In-Reply-To: <20170617150105.esceda3kiavhmu5x@ninjato>
On Sat, Jun 17, 2017 at 05:01:05PM +0200, Wolfram Sang wrote:
> On Fri, Jun 16, 2017 at 11:58:52AM +0200, Simon Horman wrote:
> > Add complete to DMA ops to allow DMAC implementation dependent
> > handling of DMA completion.
> >
> > Also implement the operation for SDHI.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Codewise, I am all fine with this patch. There is one naming, however:
>
> > + void (*complete)(struct tmio_mmc_host *host);
>
> I'd rather call it 'dataend'. For internal DMAC, it is the same. But for
> SYS-DMAC there is difference between DATAEND and DMA_COMPLETE. This is
> exactly the reason we have commit 52ad9a8e854ca1 ("mmc: tmio: ensure end
> of DMA and SD access are in sync").
>
> Basically, something like %s/complete/dataend/g would do it for me...
Sure, I will change this.
'compete' seemed like a nice name but I accept your reasoning above.
next prev parent reply other threads:[~2017-06-19 11:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 9:58 [PATCH mmc/next v2 0/4] mmc: renesas_sdhi: add support for R-Car Gen3 SDHI DMAC Simon Horman
2017-06-16 9:58 ` [PATCH mmc/next v2 1/4] mmc: tmio, renesas-sdhi: add max_{segs,blk_count} to tmio_mmc_data Simon Horman
2017-06-17 15:01 ` Wolfram Sang
2017-06-16 9:58 ` [PATCH mmc/next v2 2/4] mmc: tmio, renesas-sdhi: add complete to DMA ops Simon Horman
2017-06-17 15:01 ` Wolfram Sang
2017-06-19 11:58 ` Simon Horman [this message]
2017-06-16 9:58 ` [PATCH mmc/next v2 3/4] mmc: renesas-sdhi: add support for R-Car Gen3 SDHI DMAC Simon Horman
2017-06-17 15:00 ` Wolfram Sang
2017-06-21 9:10 ` Simon Horman
2017-06-17 20:55 ` Simon Horman
2017-06-21 9:01 ` Simon Horman
2017-06-16 9:58 ` [PATCH mmc/next v2 4/4] mmc: renesas-sdhi: remove gen3 support from SYS-DMAC driver Simon Horman
2017-06-17 15:01 ` Wolfram Sang
2017-06-17 15:03 ` [PATCH mmc/next v2 0/4] mmc: renesas_sdhi: add support for R-Car Gen3 SDHI DMAC Wolfram Sang
2017-06-19 11:59 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619115839.GC20088@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox