* [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm_guid static
@ 2017-06-19 10:55 Colin King
2017-06-19 11:01 ` Ulf Hansson
2017-06-20 7:05 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-06-19 10:55 UTC (permalink / raw)
To: Christoph Hellwig, Adrian Hunter, Ulf Hansson, linux-mmc
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The guid intel_dsm_guid does not need to be in global scope, so make
it static.
Cleans up sparse warning:
"symbol 'intel_dsm_guid' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mmc/host/sdhci-pci-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 3c02c5b394d6..f1d8385d91f0 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -404,7 +404,7 @@ struct intel_host {
bool d3_retune;
};
-const guid_t intel_dsm_guid =
+static const guid_t intel_dsm_guid =
GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm_guid static
2017-06-19 10:55 [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm_guid static Colin King
@ 2017-06-19 11:01 ` Ulf Hansson
2017-06-20 7:05 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2017-06-19 11:01 UTC (permalink / raw)
To: Colin King
Cc: Christoph Hellwig, Adrian Hunter, linux-mmc@vger.kernel.org,
kernel-janitors, linux-kernel@vger.kernel.org
On 19 June 2017 at 12:55, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
Both me and Adrian have acked this, so it's fine to pick up by Christoph.
Kind regards
Uffe
>
> The guid intel_dsm_guid does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mmc/host/sdhci-pci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 3c02c5b394d6..f1d8385d91f0 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -404,7 +404,7 @@ struct intel_host {
> bool d3_retune;
> };
>
> -const guid_t intel_dsm_guid =
> +static const guid_t intel_dsm_guid =
> GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
> 0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm_guid static
2017-06-19 10:55 [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm_guid static Colin King
2017-06-19 11:01 ` Ulf Hansson
@ 2017-06-20 7:05 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-06-20 7:05 UTC (permalink / raw)
To: Colin King
Cc: Christoph Hellwig, Adrian Hunter, Ulf Hansson, linux-mmc,
kernel-janitors, linux-kernel
Thanks Colin,
applied to uuid for-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-20 7:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-19 10:55 [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm_guid static Colin King
2017-06-19 11:01 ` Ulf Hansson
2017-06-20 7:05 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox