From: Christoph Hellwig <hch@lst.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Paolo Valente <paolo.valente@linaro.org>
Subject: Re: [PATCH 4/6 v2] mmc: block: move single ioctl() commands to block requests
Date: Wed, 5 Jul 2017 21:00:16 +0200 [thread overview]
Message-ID: <20170705190016.GA7008@lst.de> (raw)
In-Reply-To: <20170518093614.GB9250@lst.de>
Hi Linus,
On Thu, May 18, 2017 at 11:36:14AM +0200, Christoph Hellwig wrote:
> On Thu, May 18, 2017 at 11:29:34AM +0200, Linus Walleij wrote:
> > We are storing the ioctl() in/out argument as a pointer in
> > the per-request struct mmc_blk_request container.
>
> Btw, for the main ioctl data (not the little reponse field) it might
> make sense to use blk_rq_map_user, which will do a get_user_pages
> on the user data if the alignment fits, and otherwise handle the
> kernel bounce buffering for you. This should simplify the code
> quite a bit more, and in the case where you can access the user
> memory directly provide a nice little performance boost.
Did you get a chance to look into this?
next prev parent reply other threads:[~2017-07-05 19:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 9:29 [PATCH 1/6 v2] mmc: core: Delete bounce buffer Kconfig option Linus Walleij
2017-05-18 9:29 ` [PATCH 2/6 v2] mmc: core: Allocate per-request data using the block layer core Linus Walleij
2017-05-18 9:32 ` Christoph Hellwig
2017-05-18 12:39 ` Linus Walleij
2017-05-18 9:29 ` [PATCH 3/6 v2] mmc: block: Tag is_rpmb as bool Linus Walleij
2017-05-18 9:29 ` [PATCH 4/6 v2] mmc: block: move single ioctl() commands to block requests Linus Walleij
2017-05-18 9:36 ` Christoph Hellwig
2017-07-05 19:00 ` Christoph Hellwig [this message]
2017-07-31 13:44 ` Linus Walleij
2017-05-18 9:29 ` [PATCH 5/6 v2] mmc: block: move multi-ioctl() to use block layer Linus Walleij
2017-05-18 9:29 ` [PATCH 6/6 v2] mmc: queue: delete mmc_req_is_special() Linus Walleij
2017-05-19 8:30 ` [PATCH 1/6 v2] mmc: core: Delete bounce buffer Kconfig option Ulf Hansson
2017-05-19 13:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705190016.GA7008@lst.de \
--to=hch@lst.de \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox