Re: [PATCH 3/3] ARM: dts: iwg20m: Add MMCIF0 support

Simon Horman
2017-07-13T08:12:14Z

On Thu, Jul 13, 2017 at 10:02:29AM +0200, Simon Horman wrote:
> On Wed, Jul 12, 2017 at 01:52:49PM +0200, Geert Uytterhoeven wrote:
> > Hi Chris,
> >
> > On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson
> > <chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote:
> > > Define the iwg20m board dependent part of the MMCIF0 device node.
> > >
> > > Signed-off-by: Chris Paterson <chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi
> > > index 001ca91..ffce1b6 100644
> > > --- a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi
> >
> > > +&pfc {
> > > + mmcif0_pins: mmc {
> > > + groups = "mmc_data8", "mmc_ctrl";
> >
> > "mmc_data8" is not correct, as D6/D7 of the eMMC are not connected to GP6_28
> > resp. GP6_29, but to GP6_6 resp. GP6_7.
> > So it should be "mmc_data8_b".
> >
> > Unfortunately the latter pin group isn't supported by the PFC driver yet.
> > Cooking a patch...
>
> The above notwithstanding I have applied this patch for v4.14.

...

Sorry, I think I need more coffee.

I misread Geert's comment above. I have dropped this patch.
Please post a corrected v2 of this patch.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html