From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] staging: net: wireless: fix badzero.cocci warnings Date: Sun, 23 Jul 2017 16:25:28 +0800 Message-ID: <20170723082528.GA43707@lkp-nex06.lkp.intel.com> References: <201707231612.uqddXFWl%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170721143502.1991-2-quentin.schulz@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Cc: devel@driverdev.osuosl.org, ulf.hansson@linaro.org, baolin.wang@linaro.org, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, Quentin Schulz , linux-kernel@vger.kernel.org, hdegoede@redhat.com, wens@csie.org, kbuild-all@01.org, maxime.ripard@free-electrons.com, shawn.lin@rock-chips.com, icenowy@aosc.xyz List-Id: linux-mmc@vger.kernel.org drivers/staging/esp8089/esp_mac80211.c:596:33-34: WARNING comparing pointer to 0 Compare pointer-typed values to NULL rather than 0 Semantic patch information: This makes an effort to choose between !x and x == NULL. !x is used if it has previously been used with the function used to initialize x. This relies on type information. More type information can be obtained using the option -all_includes and the option -I to specify an include path. Generated by: scripts/coccinelle/null/badzero.cocci Fixes: 5ebdb57b0b15 ("staging: net: wireless: add ESP8089 WiFi driver") CC: Quentin Schulz Signed-off-by: Fengguang Wu --- esp_mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/esp8089/esp_mac80211.c +++ b/drivers/staging/esp8089/esp_mac80211.c @@ -593,7 +593,7 @@ static void hw_scan_timeout_report(struc if (test_and_clear_bit(ESP_WL_FLAG_STOP_TXQ, &epub->wl.flags)) sip_trigger_txq_process(epub->sip); /*check if normally complete or aborted like timeout/hw error */ - aborted = (epub->wl.scan_req != 0); + aborted = (epub->wl.scan_req != NULL); if (aborted) epub->wl.scan_req = NULL;