[RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1

[RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1

[Wolfram Sang]

Here is a small series to improve RZ support for SDHI. I don't have that
platform currently, so I hope Chris has some time to check these simple
patches. It is based on top of the patch just sent out:
"[PATCH] mmc: renesas_sdhi: use extra flag for CBSY usage"

Regards,

   Wolfram


Wolfram Sang (2):
  mmc: renesas_sdhi: enably CBSY bit for RZ platform
  mmc: renesas_sdhi: document version of RZ/A1 instance

 drivers/mmc/host/renesas_sdhi_core.c     | 1 +
 drivers/mmc/host/renesas_sdhi_sys_dmac.c | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.11.0

[RFT 1/2] mmc: renesas_sdhi: enably CBSY bit for RZ platform

[Wolfram Sang]

It is documented, so enable it to follow the recommendation in the docs
and also save a few cycles.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/mmc/host/renesas_sdhi_sys_dmac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
index 9b77f521cd2c2f..160fbb22ca00b4 100644
--- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
@@ -33,7 +33,8 @@ static const struct renesas_sdhi_of_data of_default_cfg = {
 };
 
 static const struct renesas_sdhi_of_data of_rz_compatible = {
-	.tmio_flags	= TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_32BIT_DATA_PORT,
+	.tmio_flags	= TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_32BIT_DATA_PORT |
+			  TMIO_MMC_HAVE_CBSY,
 	.tmio_ocr_mask	= MMC_VDD_32_33,
 	.capabilities	= MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
 };
-- 
2.11.0

[RFT 2/2] mmc: renesas_sdhi: document version of RZ/A1 instance

[Wolfram Sang]

We don't use this new define yet, but it is helpful to document which
versions we know of.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/mmc/host/renesas_sdhi_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index e46504edc9fcb4..d0554088adfc41 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -40,6 +40,7 @@
 #define EXT_ACC           0xe4
 
 #define SDHI_VER_GEN2_SDR50	0x490c
+#define SDHI_VER_RZ_A1		0x820b
 /* very old datasheets said 0x490c for SDR104, too. They are wrong! */
 #define SDHI_VER_GEN2_SDR104	0xcb0d
 #define SDHI_VER_GEN3_SD	0xcc10
-- 
2.11.0

RE: [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1

[Chris Brandt]

Hello Wolfram,


On Wednesday, August 09, 2017, Wolfram Sang wrote:
> Here is a small series to improve RZ support for SDHI. I don't have that
> platform currently, so I hope Chris has some time to check these simple
> patches. It is based on top of the patch just sent out:
> "[PATCH] mmc: renesas_sdhi: use extra flag for CBSY usage"


I applied the 3 patches and tested with an SD Card. No issues.

Thank you for considering RZ!


Chris

Re: [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1

[Simon Horman]

On Thu, Aug 10, 2017 at 12:59:05PM +0000, Chris Brandt wrote:
> Hello Wolfram,
> 
> 
> On Wednesday, August 09, 2017, Wolfram Sang wrote:
> > Here is a small series to improve RZ support for SDHI. I don't have that
> > platform currently, so I hope Chris has some time to check these simple
> > patches. It is based on top of the patch just sent out:
> > "[PATCH] mmc: renesas_sdhi: use extra flag for CBSY usage"
> 
> 
> I applied the 3 patches and tested with an SD Card. No issues.
> 
> Thank you for considering RZ!

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Re: [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1

[Ulf Hansson]

On 9 August 2017 at 21:14, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Here is a small series to improve RZ support for SDHI. I don't have that
> platform currently, so I hope Chris has some time to check these simple
> patches. It is based on top of the patch just sent out:
> "[PATCH] mmc: renesas_sdhi: use extra flag for CBSY usage"
>
> Regards,
>
>    Wolfram
>
>
> Wolfram Sang (2):
>   mmc: renesas_sdhi: enably CBSY bit for RZ platform
>   mmc: renesas_sdhi: document version of RZ/A1 instance
>
>  drivers/mmc/host/renesas_sdhi_core.c     | 1 +
>  drivers/mmc/host/renesas_sdhi_sys_dmac.c | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> --

Thanks, applied for next!

Adding tags from Simon and Chris.

Kind regards
Uffe