public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Glauber <jan.glauber@caviumnetworks.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	David Daney <david.daney@cavium.com>,
	"Steven J. Hill" <Steven.Hill@cavium.com>,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: cavium-octeon: Convert to use module_platform_driver
Date: Mon, 21 Aug 2017 12:36:51 +0200	[thread overview]
Message-ID: <20170821103651.GA12259@hc> (raw)
In-Reply-To: <20170819130611.3335-1-axel.lin@ingics.com>

On Sat, Aug 19, 2017 at 09:06:11PM +0800, Axel Lin wrote:
> Get rid of boilerplate code by using module_platform_driver macro.

Looks good. If you want to add:
Acked-by: Jan Glauber <jglauber@cavium.com>

thanks, Jan

> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/mmc/host/cavium-octeon.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/mmc/host/cavium-octeon.c b/drivers/mmc/host/cavium-octeon.c
> index 951d2cd..22aded1 100644
> --- a/drivers/mmc/host/cavium-octeon.c
> +++ b/drivers/mmc/host/cavium-octeon.c
> @@ -342,18 +342,7 @@ static struct platform_driver octeon_mmc_driver = {
>  	},
>  };
>  
> -static int __init octeon_mmc_init(void)
> -{
> -	return platform_driver_register(&octeon_mmc_driver);
> -}
> -
> -static void __exit octeon_mmc_cleanup(void)
> -{
> -	platform_driver_unregister(&octeon_mmc_driver);
> -}
> -
> -module_init(octeon_mmc_init);
> -module_exit(octeon_mmc_cleanup);
> +module_platform_driver(octeon_mmc_driver);
>  
>  MODULE_AUTHOR("Cavium Inc. <support@cavium.com>");
>  MODULE_DESCRIPTION("Low-level driver for Cavium OCTEON MMC/SSD card");
> -- 
> 2.9.3

  reply	other threads:[~2017-08-21 10:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-19 13:06 [PATCH] mmc: cavium-octeon: Convert to use module_platform_driver Axel Lin
2017-08-21 10:36 ` Jan Glauber [this message]
2017-08-22 11:15 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821103651.GA12259@hc \
    --to=jan.glauber@caviumnetworks.com \
    --cc=Steven.Hill@cavium.com \
    --cc=axel.lin@ingics.com \
    --cc=david.daney@cavium.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox