Re: [PATCH V5 04/13] mmc: core: Turn off CQE before sending commands

Ulf Hansson
2017-08-22T11:13:22Z

On 10 August 2017 at 14:08, Adrian Hunter <adrian.hunter@intel.com> wrote:
> CQE needs to be off for the host controller to accept non-CQ commands. Turn
> off the CQE before sending commands, and ensure it is off in any reset or
> power management paths, or re-tuning.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
> drivers/mmc/core/core.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 6177eb09bf1b..29544aa2824a 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -260,6 +260,9 @@ static void __mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
>
> trace_mmc_request_start(host, mrq);
>
> + if (host->cqe_on)
> + host->cqe_ops->cqe_off(host);
> +
> host->ops->request(host, mrq);
> }
>
> @@ -979,6 +982,9 @@ int mmc_execute_tuning(struct mmc_card *card)
> if (!host->ops->execute_tuning)
> return 0;
>
> + if (host->cqe_on)
> + host->cqe_ops->cqe_off(host);
> +
> if (mmc_card_mmc(card))
> opcode = MMC_SEND_TUNING_BLOCK_HS200;
> else
> @@ -1018,6 +1024,9 @@ void mmc_set_bus_width(struct mmc_host *host, unsigned int width)
> */
> void mmc_set_initial_state(struct mmc_host *host)
> {
> + if (host->cqe_on)
> + host->cqe_ops->cqe_off(host);
> +
> mmc_retune_disable(host);
>
> if (mmc_host_is_spi(host))
> --
> 1.9.1
>