Re: [PATCH V5 09/13] mmc: block: Use local variables in mmc_blk_data_prep()

Linus Walleij
2017-08-20T11:43:34Z

On Thu, Aug 10, 2017 at 2:08 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:

> Use local variables in mmc_blk_data_prep() in preparation for adding CQE
> support which doesn't use the output variables.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
on the patch as such but:

> static void mmc_blk_data_prep(struct mmc_queue *mq, struct mmc_queue_req *mqrq,
> - int disable_multi, bool *do_rel_wr,
> - bool *do_data_tag)
> + int disable_multi, bool *do_rel_wr_p,
> + bool *do_data_tag_p)

We need to figure out what we mean by "tag" in eMMC.

Yours,
Linus Walleij