Re: [PATCH V5 05/13] mmc: core: Add support for handling CQE requests

Adrian Hunter
2017-08-21T09:33:21Z

On 20/08/17 14:39, Linus Walleij wrote:
> On Thu, Aug 10, 2017 at 2:08 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>
>> Add core support for handling CQE requests, including starting, completing
>> and recovering.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>
>
>> +static void __mmc_cqe_request_done(struct mmc_host *host,
>> + struct mmc_request *mrq)
>
> We are naming too much stuff __foo now, it gets really hard to figure
> out from the function name and the surrounding code what is going on.

You have written several times that you don't like __foo() names, however it
is a normal kernel paradigm.

> I guess people are using this like "do parts of what mmc_cqe_request_done()
> is doing" but it'd be nice if we could be specific.
>
> mmc_cqe_request_finalize() could work?

It can be rolled into mmc_cqe_request_done().