* [PATCH] mmc: cavium: Depend on GPIO driver
@ 2017-10-02 12:02 Jan Glauber
2017-10-02 17:06 ` David Daney
2017-10-04 8:59 ` Ulf Hansson
0 siblings, 2 replies; 4+ messages in thread
From: Jan Glauber @ 2017-10-02 12:02 UTC (permalink / raw)
To: Ulf Hansson; +Cc: linux-mmc, David Daney, Steven J. Hill, Jan Glauber
Without the ThunderX/OcteonTx GPIO driver the MMC driver
would not power up any MMC devices. Therefore add a
dependency to the GPIO driver and remove the unneeded GPIOLIB
dependency.
Signed-off-by: Jan Glauber <jglauber@cavium.com>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 8c15637178ff..a47a2f1d8ae4 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -663,7 +663,7 @@ config MMC_CAVIUM_OCTEON
config MMC_CAVIUM_THUNDERX
tristate "Cavium ThunderX SD/MMC Card Interface support"
depends on PCI && 64BIT && (ARM64 || COMPILE_TEST)
- depends on GPIOLIB
+ depends on GPIO_THUNDERX
depends on OF_ADDRESS
help
This selects Cavium ThunderX SD/MMC Card Interface.
--
2.9.0.rc0.21.g7777322
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: cavium: Depend on GPIO driver
2017-10-02 12:02 [PATCH] mmc: cavium: Depend on GPIO driver Jan Glauber
@ 2017-10-02 17:06 ` David Daney
2017-10-04 14:12 ` Jan Glauber
2017-10-04 8:59 ` Ulf Hansson
1 sibling, 1 reply; 4+ messages in thread
From: David Daney @ 2017-10-02 17:06 UTC (permalink / raw)
To: Jan Glauber, Ulf Hansson; +Cc: linux-mmc, David Daney, Steven J. Hill
On 10/02/2017 05:02 AM, Jan Glauber wrote:
> Without the ThunderX/OcteonTx GPIO driver the MMC driver
> would not power up any MMC devices. Therefore add a
> dependency to the GPIO driver and remove the unneeded GPIOLIB
> dependency.
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 8c15637178ff..a47a2f1d8ae4 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -663,7 +663,7 @@ config MMC_CAVIUM_OCTEON
> config MMC_CAVIUM_THUNDERX
> tristate "Cavium ThunderX SD/MMC Card Interface support"
> depends on PCI && 64BIT && (ARM64 || COMPILE_TEST)
> - depends on GPIOLIB
> + depends on GPIO_THUNDERX
We could just "select" GPIO_THUNDERX instead so that people aren't
forced to manually unwind all the dependencies.
Also, what do we do if the required GPIO lines are on I2C expanders?
This patch doesn't help in this hypothetical case. In the end it is the
responsibility if the system designer to ensure the proper drivers are
available in their kernels. I think the patch is a step in the right
direction, but just wanted to note that it doesn't cover all possible cases.
In any event, you can add ...:
Acked-by: David Daney <david.daney@cavium.com>
... to either this version, or an alternative patch that does the
"select" instead.
Thanks
> depends on OF_ADDRESS
> help
> This selects Cavium ThunderX SD/MMC Card Interface.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: cavium: Depend on GPIO driver
2017-10-02 17:06 ` David Daney
@ 2017-10-04 14:12 ` Jan Glauber
0 siblings, 0 replies; 4+ messages in thread
From: Jan Glauber @ 2017-10-04 14:12 UTC (permalink / raw)
To: David Daney; +Cc: Ulf Hansson, linux-mmc, David Daney, Steven J. Hill
On Mon, Oct 02, 2017 at 10:06:05AM -0700, David Daney wrote:
> On 10/02/2017 05:02 AM, Jan Glauber wrote:
> >Without the ThunderX/OcteonTx GPIO driver the MMC driver
> >would not power up any MMC devices. Therefore add a
> >dependency to the GPIO driver and remove the unneeded GPIOLIB
> >dependency.
> >
> >Signed-off-by: Jan Glauber <jglauber@cavium.com>
> >---
> > drivers/mmc/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> >index 8c15637178ff..a47a2f1d8ae4 100644
> >--- a/drivers/mmc/host/Kconfig
> >+++ b/drivers/mmc/host/Kconfig
> >@@ -663,7 +663,7 @@ config MMC_CAVIUM_OCTEON
> > config MMC_CAVIUM_THUNDERX
> > tristate "Cavium ThunderX SD/MMC Card Interface support"
> > depends on PCI && 64BIT && (ARM64 || COMPILE_TEST)
> >- depends on GPIOLIB
> >+ depends on GPIO_THUNDERX
>
> We could just "select" GPIO_THUNDERX instead so that people aren't
> forced to manually unwind all the dependencies.
I thought about select vs. depends, but the Documentation prefers
depends as a select would not automatically enable everything
GPIO_THUNDERX needs. See in Documentation/kbuild/kconfig-language.txt
the note about select.
--Jan
> Also, what do we do if the required GPIO lines are on I2C expanders?
> This patch doesn't help in this hypothetical case. In the end it is
> the responsibility if the system designer to ensure the proper
> drivers are available in their kernels. I think the patch is a step
> in the right direction, but just wanted to note that it doesn't
> cover all possible cases.
>
> In any event, you can add ...:
>
> Acked-by: David Daney <david.daney@cavium.com>
>
> ... to either this version, or an alternative patch that does the
> "select" instead.
>
> Thanks
>
>
> > depends on OF_ADDRESS
> > help
> > This selects Cavium ThunderX SD/MMC Card Interface.
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: cavium: Depend on GPIO driver
2017-10-02 12:02 [PATCH] mmc: cavium: Depend on GPIO driver Jan Glauber
2017-10-02 17:06 ` David Daney
@ 2017-10-04 8:59 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2017-10-04 8:59 UTC (permalink / raw)
To: Jan Glauber; +Cc: linux-mmc@vger.kernel.org, David Daney, Steven J. Hill
On 2 October 2017 at 14:02, Jan Glauber <jglauber@cavium.com> wrote:
> Without the ThunderX/OcteonTx GPIO driver the MMC driver
> would not power up any MMC devices. Therefore add a
> dependency to the GPIO driver and remove the unneeded GPIOLIB
> dependency.
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 8c15637178ff..a47a2f1d8ae4 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -663,7 +663,7 @@ config MMC_CAVIUM_OCTEON
> config MMC_CAVIUM_THUNDERX
> tristate "Cavium ThunderX SD/MMC Card Interface support"
> depends on PCI && 64BIT && (ARM64 || COMPILE_TEST)
> - depends on GPIOLIB
> + depends on GPIO_THUNDERX
> depends on OF_ADDRESS
> help
> This selects Cavium ThunderX SD/MMC Card Interface.
> --
> 2.9.0.rc0.21.g7777322
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-04 14:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-02 12:02 [PATCH] mmc: cavium: Depend on GPIO driver Jan Glauber
2017-10-02 17:06 ` David Daney
2017-10-04 14:12 ` Jan Glauber
2017-10-04 8:59 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox