linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] ANDROID: mmc: core: export emmc revision
@ 2017-10-11 19:23 Jin Qian
  2017-10-11 20:18 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Jin Qian @ 2017-10-11 19:23 UTC (permalink / raw)
  To: Ulf Hansson, Shawn Lin, Adrian Hunter, Linus Walleij,
	Jaehoon Chung, Uri Yanai, Chanho Min, Jungseung Lee, linux-mmc,
	linux-kernel
  Cc: Jin Qian, Jin Qian

From: Jin Qian <jinqian@google.com>

Expose emmc revision as part of device attributes.

Signed-off-by: Jin Qian <jinqian@android.com>
---
 drivers/mmc/core/mmc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 36217ad5e9b1..4aa4cfb2c9e1 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -780,6 +780,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
 MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
 MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
 MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
+MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
 MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
 MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n",
 	card->ext_csd.device_life_time_est_typ_a,
@@ -838,6 +839,7 @@ static struct attribute *mmc_std_attrs[] = {
 	&dev_attr_name.attr,
 	&dev_attr_oemid.attr,
 	&dev_attr_prv.attr,
+	&dev_attr_rev.attr,
 	&dev_attr_pre_eol_info.attr,
 	&dev_attr_life_time.attr,
 	&dev_attr_serial.attr,
-- 
2.15.0.rc0.271.g36b669edcc-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] ANDROID: mmc: core: export emmc revision
  2017-10-11 19:23 [PATCH 1/1] ANDROID: mmc: core: export emmc revision Jin Qian
@ 2017-10-11 20:18 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-10-11 20:18 UTC (permalink / raw)
  To: Jin Qian
  Cc: Ulf Hansson, Shawn Lin, Adrian Hunter, Linus Walleij,
	Jaehoon Chung, Uri Yanai, Chanho Min, Jungseung Lee, linux-mmc,
	linux-kernel, Jin Qian

On Wed, Oct 11, 2017 at 12:23:18PM -0700, Jin Qian wrote:
> From: Jin Qian <jinqian@google.com>
> 
> Expose emmc revision as part of device attributes.
> 
> Signed-off-by: Jin Qian <jinqian@android.com>
> ---
>  drivers/mmc/core/mmc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 36217ad5e9b1..4aa4cfb2c9e1 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -780,6 +780,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
>  MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
>  MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
>  MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
> +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);


Is there a Documentation/ABI/ update as well to describe exactly what
this sysfs attribute contains?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-11 20:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-11 19:23 [PATCH 1/1] ANDROID: mmc: core: export emmc revision Jin Qian
2017-10-11 20:18 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).