From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-mmc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: [PATCH v2 06/11] mmc: mmci: catch all errors when getting regulators
Date: Sat, 14 Oct 2017 21:17:14 +0200 [thread overview]
Message-ID: <20171014191719.2129-7-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20171014191719.2129-1-wsa+renesas@sang-engineering.com>
Bail out everytime when mmc_regulator_get_supply() returns an errno, not
only when probing gets deferred. This is currently a no-op, because this
function only returns -EPROBE_DEFER or 0 right now. But if it will throw
another error somewhen, it will be for a reason. (This still doesn't change
that getting regulators is optional, so 0 can still mean no regulators
found). So, let us a) be future proof and b) have driver code which is
easier to understand.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/mmci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index f1f54a81848951..e8a1bb1ae69423 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -1658,7 +1658,7 @@ static int mmci_probe(struct amba_device *dev,
/* Get regulators and the supported OCR mask */
ret = mmc_regulator_get_supply(mmc);
- if (ret == -EPROBE_DEFER)
+ if (ret)
goto clk_disable;
if (!mmc->ocr_avail)
--
2.11.0
next prev parent reply other threads:[~2017-10-14 19:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 19:17 [PATCH v2 00/11] mmc: document mmc_regulator_get_supply and fix users Wolfram Sang
2017-10-14 19:17 ` [PATCH v2 01/11] mmc: add kerneldoc to mmc_regulator_get_supply() Wolfram Sang
2017-10-14 19:17 ` [PATCH v2 02/11] mmc: cavium: catch all errors when getting regulators Wolfram Sang
2017-10-14 19:17 ` [PATCH v2 03/11] mmc: dw_mmc: " Wolfram Sang
2017-10-14 19:17 ` [PATCH v2 04/11] mmc: meson-gx-mmc: " Wolfram Sang
2017-10-14 19:17 ` [PATCH v2 05/11] mmc: meson-mx-sdio: " Wolfram Sang
2017-10-14 19:17 ` Wolfram Sang [this message]
2017-10-14 19:17 ` [PATCH v2 07/11] mmc: mtk-sd: " Wolfram Sang
2017-10-14 19:17 ` [PATCH v2 08/11] mmc: mxcmmc: " Wolfram Sang
2017-10-14 19:17 ` [PATCH v2 09/11] mmc: omap_hsmmc: " Wolfram Sang
2017-10-14 19:17 ` [PATCH v2 10/11] mmc: sdhci: " Wolfram Sang
2017-10-14 19:17 ` [PATCH v2 11/11] mmc: usdhi6rol0: " Wolfram Sang
2017-10-20 10:02 ` [PATCH v2 00/11] mmc: document mmc_regulator_get_supply and fix users Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171014191719.2129-7-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).