From: Jan Glauber <jan.glauber@caviumnetworks.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Shawn Lin <shawn.lin@rock-chips.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"Steven J. Hill" <Steven.Hill@cavium.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 1/3] mmc: core: activate pre-erased multiple write support for sd card
Date: Thu, 26 Oct 2017 13:03:16 +0200 [thread overview]
Message-ID: <20171026110316.GD12640@hc> (raw)
In-Reply-To: <CAPDyKFrdXPp4+Gu_2uE_Kdw0vLFC3uQ7ZBc9kYa+HKCgYc06Vg@mail.gmail.com>
On Thu, Oct 26, 2017 at 12:46:02PM +0200, Ulf Hansson wrote:
> On 26 October 2017 at 03:19, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> > Hi, Ulf
> >
> > On 2017/9/27 11:40, Shawn Lin wrote:
> >>
> >> Per SD specification version 4.10, section 4.3.4, it says "pre-erased
> >> (ACMD23) will make a following Multiple Block Write operation faster
> >> compared to the same operation without preceding ACMD23". ACMD23 is
> >> mandatory for all sd cards and the spec also says "Command STOP_TRAN
> >> (CMD12) shall be used to stop the transmission in Write Multiple Block
> >> whether or not the preerase (ACMD23) feature is used."
> >
> >
> > Ping... :)
>
> Hi Shawn,
>
> Actually I was waiting for confirmation from Jan about his tests.
The patches worked for me but I'm not sure I've actually tested ACMD23.
Do I need to trigger ACMD23 somehow?
--Jan
> However, overall the series looks reasonable to me.
>
> Kind regards
> Uffe
next prev parent reply other threads:[~2017-10-26 11:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 3:40 [PATCH 1/3] mmc: core: activate pre-erased multiple write support for sd card Shawn Lin
2017-09-27 3:40 ` [PATCH 2/3] mmc: test: prepare sbc for preceding ACMD23 multiple block write Shawn Lin
2017-09-27 3:40 ` [PATCH 3/3] mmc: cavium: Add ACMD23 support for dma's multiple mode Shawn Lin
2017-09-27 13:47 ` [PATCH 1/3] mmc: core: activate pre-erased multiple write support for sd card Jan Glauber
2017-09-28 3:33 ` Shawn Lin
2017-09-28 14:29 ` Jan Glauber
2017-10-26 1:19 ` Shawn Lin
2017-10-26 10:46 ` Ulf Hansson
2017-10-26 11:03 ` Jan Glauber [this message]
2017-10-27 1:46 ` Shawn Lin
2017-10-27 12:36 ` Jan Glauber
2017-10-26 11:32 ` Adrian Hunter
2017-10-27 1:52 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026110316.GD12640@hc \
--to=jan.glauber@caviumnetworks.com \
--cc=Steven.Hill@cavium.com \
--cc=adrian.hunter@intel.com \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox