From: Wolfram Sang <wsa@the-dreams.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Simon Horman <horms+renesas@verge.net.au>,
linux-mmc <linux-mmc@vger.kernel.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: More TMIO MMC variant. What is a preferred name?
Date: Tue, 21 Nov 2017 21:01:11 +0100 [thread overview]
Message-ID: <20171121200111.vrpmsubme55356qv@ninjato> (raw)
In-Reply-To: <CAPDyKFq_uVvBKBhATNYhq2mSMmNXA7tPSSPMESCnTDtQt9XrZA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
Hi Ulf,
thanks for the feedback!
> So what do you think of this?:
>
> 1) Rename tmio_core.c to tmio.c, and fold in some more information
> about the history of the IP in the header of the file. Yeah, "tmio"
> may not be the absolutely correct name, but on the other hand it
> preserves consistency and I there are no need to rename any functions.
> 2) Rename tmio_mmc.h to tmio.h - and move potential tmio_mmc specific
> bits to tmio_mmc.c.
> 3) Rename renesas_sdhi_core.c to tmio_renesas_sdhi.c. Again, I don't
> think we need any functions to be renamed because of this change.
> 4) Rename renesas_sdhi.h to tmio_renesas_sdhi.h.
I can agree to that. Clarifying 3), I think though, we should have:
tmio_sdhi.c
and on top of that:
tmio_sdhi_internal_dmac.c
tmio_sdhi_sys_dmac.c
?
> Following the naming strategy from the above, I the new file name for
> new tmio variant should be tmio_uniphier.c.
Yes.
Kind regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-21 20:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 7:52 More TMIO MMC variant. What is a preferred name? Masahiro Yamada
2017-11-08 17:53 ` Wolfram Sang
2017-11-09 12:31 ` Masahiro Yamada
2017-11-20 20:11 ` Wolfram Sang
2017-11-21 11:32 ` Ulf Hansson
2017-11-21 20:01 ` Wolfram Sang [this message]
2017-11-21 20:14 ` Ulf Hansson
2017-11-22 1:16 ` Masahiro Yamada
2017-11-22 1:20 ` Masahiro Yamada
2017-11-22 7:59 ` Wolfram Sang
2017-11-22 13:22 ` Masahiro Yamada
2017-11-22 15:18 ` Ulf Hansson
2017-11-22 17:08 ` Wolfram Sang
2017-11-23 7:04 ` Ulf Hansson
2017-11-27 17:14 ` Wolfram Sang
2017-11-28 8:04 ` Masahiro Yamada
2017-12-08 14:59 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121200111.vrpmsubme55356qv@ninjato \
--to=wsa@the-dreams.de \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox