[ulf.hansson-mmc:next 27/28] drivers/mmc/core/block.c:2106:9-10: WARNING: return of 0/1 in function 'mmc_blk_status_error' with return type bool

[ulf.hansson-mmc:next 27/28] drivers/mmc/core/block.c:2106:9-10: WARNING: return of 0/1 in function 'mmc_blk_status_error' with return type bool

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
head:   98f67755cf2dc07fc0d79c534deb28634b58e391
commit: 89eb3e6b5f77fe3d5579adc13f75d610487e03c3 [27/28] mmc: block: blk-mq: Stop using legacy recovery


coccinelle warnings: (new ones prefixed by >>)

>> drivers/mmc/core/block.c:2106:9-10: WARNING: return of 0/1 in function 'mmc_blk_status_error' with return type bool

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[PATCH] mmc: block: blk-mq: fix boolreturn.cocci warnings

[kbuild test robot]

drivers/mmc/core/block.c:2106:9-10: WARNING: return of 0/1 in function 'mmc_blk_status_error' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 89eb3e6b5f77 ("mmc: block: blk-mq: Stop using legacy recovery")
CC: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 block.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -2103,7 +2103,7 @@ static bool mmc_blk_status_error(struct
 	u32 stop_err_bits;
 
 	if (mmc_host_is_spi(mq->card->host))
-		return 0;
+		return false;
 
 	stop_err_bits = mmc_blk_stop_err_bits(brq);
 

Re: [PATCH] mmc: block: blk-mq: fix boolreturn.cocci warnings

[Adrian Hunter]

On 29/11/17 23:54, kbuild test robot wrote:
> drivers/mmc/core/block.c:2106:9-10: WARNING: return of 0/1 in function 'mmc_blk_status_error' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: 89eb3e6b5f77 ("mmc: block: blk-mq: Stop using legacy recovery")
> CC: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> 
>  block.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -2103,7 +2103,7 @@ static bool mmc_blk_status_error(struct
>  	u32 stop_err_bits;
>  
>  	if (mmc_host_is_spi(mq->card->host))
> -		return 0;
> +		return false;
>  
>  	stop_err_bits = mmc_blk_stop_err_bits(brq);
>  
> 

Re: [PATCH] mmc: block: blk-mq: fix boolreturn.cocci warnings

[Ulf Hansson]

On 29 November 2017 at 22:54, kbuild test robot <fengguang.wu@intel.com> wrote:
> drivers/mmc/core/block.c:2106:9-10: WARNING: return of 0/1 in function 'mmc_blk_status_error' with return type bool
>
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: 89eb3e6b5f77 ("mmc: block: blk-mq: Stop using legacy recovery")
> CC: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  block.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -2103,7 +2103,7 @@ static bool mmc_blk_status_error(struct
>         u32 stop_err_bits;
>
>         if (mmc_host_is_spi(mq->card->host))
> -               return 0;
> +               return false;
>
>         stop_err_bits = mmc_blk_stop_err_bits(brq);
>