public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <drake@endlessm.com>
To: ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, linux@endlessm.com,
	matthew.leeds@endlessm.com
Subject: [PATCH] mmc: allow rescan of non-removable hosts on resume
Date: Wed,  6 Dec 2017 10:57:24 +0000	[thread overview]
Message-ID: <20171206105724.5603-1-drake@endlessm.com> (raw)

The Weibu F3C MiniPC has an onboard AP6255 module, presenting
two SDIO functions on a single MMC host (Bluetooth/btsdio and
WiFi/brcmfmac), and the mmc layer correctly detects this as
non-removable.

After suspend/resume, the wifi and bluetooth interfaces disappear
and do not get probed again.

The conditions here are:

 1. During suspend, we reach mmc_pm_notify()

 2. mmc_pm_notify() calls mmc_sdio_pre_suspend() to see if we can
    suspend the SDIO host. However, mmc_sdio_pre_suspend() returns
    -ENOSYS because btsdio_driver does not have a suspend method.

 3. mmc_pm_notify() proceeds to remove the card

 4. Upon resume, mmc_rescan() does nothing with this host, because of
    the rescan_entered check which aims to only scan a non-removable
    device a single time (i.e. during boot).

Fix the loss of functionality by permitting another rescan of
non-removable devices when we forcefully remove a card under these
conditions.

Signed-off-by: Daniel Drake <drake@endlessm.com>
---
 drivers/mmc/core/core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 1f0f44f4dd5f..e436cde50bc4 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -2966,6 +2966,10 @@ static int mmc_pm_notify(struct notifier_block *notify_block,
 		mmc_power_off(host);
 		mmc_release_host(host);
 		host->pm_flags = 0;
+
+		/* Force a rescan on resume, even for non-removable cards */
+		host->rescan_entered = 0;
+
 		break;
 
 	case PM_POST_SUSPEND:
-- 
2.14.1


             reply	other threads:[~2017-12-06 10:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 10:57 Daniel Drake [this message]
2017-12-11 13:11 ` [PATCH] mmc: allow rescan of non-removable hosts on resume Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171206105724.5603-1-drake@endlessm.com \
    --to=drake@endlessm.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=matthew.leeds@endlessm.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox