public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: More TMIO MMC variant. What is a preferred name?
Date: Fri, 8 Dec 2017 15:59:56 +0100	[thread overview]
Message-ID: <20171208145955.av4uhpluldbhshog@ninjato> (raw)
In-Reply-To: <CAK7LNAQtLdXBw_JzW2dYdVtC0b6eGCvO5KByXfKKJVxi02i61g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

Yamada-san, Ulf,

> How about CONFIG names and functions?
> Prefix CONFIG options with CONFIG_MMC_TMIO ?

To be precise, I'd favour this:

# core
obj-$(CONFIG_MMC_TMIO_CORE)           += tmio_mmc_core.o
# TMIO-builtin MMC
obj-$(CONFIG_MMC_TMIO_ORIGINAL)       += tmio_mmc_original.o
# Reneses
obj-$(CONFIG_MMC_TMIO_SDHI_CORE)      += tmio_mmc_sdhi_core.o
# UniPhier
obj-$(CONFIG_MMC_TMIO_UNIPHIER)       += tmio_mmc_uniphier.o

But I am not sure if renaming CONFIG_MMC_TMIO to
CONFIG_MMC_TMIO_ORIGINAL is a regression risk?

> What should I do for function names?
> Shall I start with tmio_mmc_uniphier_ ?

I'll leave this to you and Ulf. If we e.g. rename "renesas_sdhi_core.c"
to "tmio_mmc_sdhi_core.c", I would still leave the function names as is
(prefixed with 'renesas_sdhi_*'). I wouldn't mind your functions
starting with "uniphier_mmc_" even, but that's just me.

Thanks,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2017-12-08 15:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07  7:52 More TMIO MMC variant. What is a preferred name? Masahiro Yamada
2017-11-08 17:53 ` Wolfram Sang
2017-11-09 12:31   ` Masahiro Yamada
2017-11-20 20:11     ` Wolfram Sang
2017-11-21 11:32       ` Ulf Hansson
2017-11-21 20:01         ` Wolfram Sang
2017-11-21 20:14           ` Ulf Hansson
2017-11-22  1:16             ` Masahiro Yamada
2017-11-22  1:20               ` Masahiro Yamada
2017-11-22  7:59               ` Wolfram Sang
2017-11-22 13:22                 ` Masahiro Yamada
2017-11-22 15:18               ` Ulf Hansson
2017-11-22 17:08               ` Wolfram Sang
2017-11-23  7:04                 ` Ulf Hansson
2017-11-27 17:14                   ` Wolfram Sang
2017-11-28  8:04                     ` Masahiro Yamada
2017-12-08 14:59                       ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208145955.av4uhpluldbhshog@ninjato \
    --to=wsa@the-dreams.de \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-mmc@vger.kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yamada.masahiro@socionext.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox