* [PATCH 03/11] mmc: kconfig: Remove blank help text [not found] <20180131093434.20050-1-ulfalizer@gmail.com> @ 2018-01-31 9:34 ` Ulf Magnusson 2018-02-01 17:09 ` Masahiro Yamada 0 siblings, 1 reply; 3+ messages in thread From: Ulf Magnusson @ 2018-01-31 9:34 UTC (permalink / raw) To: linux-kbuild Cc: linux-kernel, yamada.masahiro, mcgrof, rdunlap, dan.carpenter, pebolle, Ulf Magnusson, Ulf Hansson, Adrian Hunter, Wolfram Sang, Shawn Lin, Simon Horman, Jan Glauber, Eric Anholt, Carlo Caione, Venkat Gopalakrishnan, Kishon Vijay Abraham I, Andy Shevchenko, Rui Feng, linux-mmc Blank help texts are probably either a typo, a Kconfig misunderstanding, or some kind of half-committing to adding a help text (in which case a TODO comment would be clearer, if the help text really can't be added right away). Best to remove them, IMO. Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> --- drivers/mmc/host/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 67bd3344dd03..24dee8eb5270 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -874,7 +874,6 @@ config MMC_CQHCI config MMC_TOSHIBA_PCI tristate "Toshiba Type A SD/MMC Card Interface Driver" depends on PCI - help config MMC_BCM2835 tristate "Broadcom BCM2835 SDHOST MMC Controller support" -- 2.14.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 03/11] mmc: kconfig: Remove blank help text 2018-01-31 9:34 ` [PATCH 03/11] mmc: kconfig: Remove blank help text Ulf Magnusson @ 2018-02-01 17:09 ` Masahiro Yamada 2018-02-14 10:11 ` Ulf Hansson 0 siblings, 1 reply; 3+ messages in thread From: Masahiro Yamada @ 2018-02-01 17:09 UTC (permalink / raw) To: Ulf Magnusson Cc: Linux Kbuild mailing list, Linux Kernel Mailing List, Luis R. Rodriguez, Randy Dunlap, Dan Carpenter, Paul Bolle, Ulf Hansson, Adrian Hunter, Wolfram Sang, Shawn Lin, Simon Horman, Jan Glauber, Eric Anholt, Carlo Caione, Venkat Gopalakrishnan, Kishon Vijay Abraham I, Andy Shevchenko, Rui Feng 2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>: > Blank help texts are probably either a typo, a Kconfig misunderstanding, > or some kind of half-committing to adding a help text (in which case a > TODO comment would be clearer, if the help text really can't be added > right away). > > Best to remove them, IMO. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- FYI. I picked up this patch to kbuild because I need this to suppress warning messages introduced by 11/11. I am planning to send a PR for this series next week. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 03/11] mmc: kconfig: Remove blank help text 2018-02-01 17:09 ` Masahiro Yamada @ 2018-02-14 10:11 ` Ulf Hansson 0 siblings, 0 replies; 3+ messages in thread From: Ulf Hansson @ 2018-02-14 10:11 UTC (permalink / raw) To: Masahiro Yamada Cc: Ulf Magnusson, Linux Kbuild mailing list, Linux Kernel Mailing List, Luis R. Rodriguez, Randy Dunlap, Dan Carpenter, Paul Bolle, Adrian Hunter, Wolfram Sang, Shawn Lin, Simon Horman, Jan Glauber, Eric Anholt, Carlo Caione, Venkat Gopalakrishnan, Kishon Vijay Abraham I, Andy Shevchenko, Rui Feng On 1 February 2018 at 18:09, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > 2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>: >> Blank help texts are probably either a typo, a Kconfig misunderstanding, >> or some kind of half-committing to adding a help text (in which case a >> TODO comment would be clearer, if the help text really can't be added >> right away). >> >> Best to remove them, IMO. >> >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> >> --- > > > FYI. > > I picked up this patch to kbuild > because I need this to suppress warning messages > introduced by 11/11. Okay. Feel free to add my ack. [...] Kind regards Uffe ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-14 10:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180131093434.20050-1-ulfalizer@gmail.com>
2018-01-31 9:34 ` [PATCH 03/11] mmc: kconfig: Remove blank help text Ulf Magnusson
2018-02-01 17:09 ` Masahiro Yamada
2018-02-14 10:11 ` Ulf Hansson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox