From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 3/3] mmc: renesas_sdhi: add eMMC HS400 mode support
Date: Tue, 13 Feb 2018 14:01:14 +0100 [thread overview]
Message-ID: <20180213130114.frishm3mflriz45z@katana> (raw)
In-Reply-To: <20180213113843.enfk3jhjgpfvvlsc@verge.net.au>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Tue, Feb 13, 2018 at 12:38:44PM +0100, Simon Horman wrote:
> On Wed, Feb 07, 2018 at 11:21:44PM +0100, Wolfram Sang wrote:
> >
> > > + /* Reset HS400 mode */
> > > + sd_ctrl_write16(host, CTL_SDIF_MODE, ~0x0001 &
> > > + sd_ctrl_read16(host, CTL_SDIF_MODE));
> > > + sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_TMPPORT2,
> > > + ~(SH_MOBILE_SDHI_SCC_TMPPORT2_HS400EN |
> > > + SH_MOBILE_SDHI_SCC_TMPPORT2_HS400OSEL) &
> > > + sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_TMPPORT2));
> > > +
> >
> > This looks like code duplication. Can't we simply call
> > renesas_sdhi_reset_hs400_mode()?
>
> Yes, thanks for noticing. I will make that so.
>
> I think that the previous few lines, not added by this patch,
> can also be consolidated into a renesas_sdhi_reset_scc() function
> and re-used in renesas_sdhi_reset_scc().
Even better!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-13 13:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 13:39 [PATCH v2 0/3] mmc: renesas_sdhi: add eMMC HS400 mode support Simon Horman
2018-01-19 13:39 ` [PATCH v2 1/3] mmc: tmio: correct treatment of errors during tuning Simon Horman
2018-02-07 21:52 ` Wolfram Sang
2018-02-13 11:31 ` Simon Horman
2018-02-13 12:55 ` Wolfram Sang
2018-01-19 13:39 ` [PATCH v2 2/3] mmc: tmio: add eMMC HS400 mode support Simon Horman
2018-02-07 22:20 ` Wolfram Sang
2018-02-13 11:33 ` Simon Horman
2018-02-13 13:00 ` Wolfram Sang
2018-01-19 13:39 ` [PATCH v2 3/3] mmc: renesas_sdhi: " Simon Horman
2018-02-07 22:21 ` Wolfram Sang
2018-02-13 11:38 ` Simon Horman
2018-02-13 13:01 ` Wolfram Sang [this message]
2018-02-07 22:26 ` [PATCH v2 0/3] " Wolfram Sang
2018-02-08 11:37 ` Simon Horman
2018-02-13 11:47 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213130114.frishm3mflriz45z@katana \
--to=wsa@the-dreams.de \
--cc=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox