From: "ernest.zhang" <ernest.zhang@bayhubtech.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ernest.zhang@bayhubtech.com, chuanjin.pang@bayhubtech.com,
mike.li@bayhubtech.com, chevron.li@bayhubtech.com,
shirley.her@bayhubtech.com, xiaoguang.yu@bayhubtech.com,
bobby.wu@bayhubtech.com
Subject: [PATCH V6 3/3] mmc: sdhci: Add MSI interrupt support for O2 SD host
Date: Tue, 26 Jun 2018 23:46:47 +0800 [thread overview]
Message-ID: <20180626154647.11623-3-ernest.zhang@bayhubtech.com> (raw)
In-Reply-To: <20180626154647.11623-1-ernest.zhang@bayhubtech.com>
Add MSI interrupt support if the SD host device can support MSI interrupt.
Signed-off-by: ernest.zhang <ernest.zhang@bayhubtech.com>
---
Changes in V6:
1. Move change log to correct place.
2. Reduce unneeded pr_info prints.
3. In function sdhci_pci_o2_probe_slot, remove using local
variable 'mmc' instead of using 'host->mmc'.
3. Make the msi enable code a sperate function.
Changes in V5:
1. Because pci_enable_msi is marked as deprecated and should not be
used in new code, use pci_alloc_irq_vectors instead.
2. Remove unneeded CONFIG_PCI_MSI macro check.
Changes in V4:
Enable MSI interrupt if the MSI capability bit is set in
capability register.
---
drivers/mmc/host/sdhci-pci-o2micro.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
index 7747e8b..56bc717 100644
--- a/drivers/mmc/host/sdhci-pci-o2micro.c
+++ b/drivers/mmc/host/sdhci-pci-o2micro.c
@@ -260,6 +260,29 @@ static void sdhci_pci_o2_fujin2_pci_init(struct sdhci_pci_chip *chip)
pci_write_config_dword(chip->pdev, O2_SD_MISC_CTRL4, scratch_32);
}
+static void sdhci_pci_o2_enable_msi(struct sdhci_pci_chip *chip,
+ struct sdhci_host *host)
+{
+ int ret;
+
+ ret = pci_find_capability(chip->pdev, PCI_CAP_ID_MSI);
+ if (!ret) {
+ pr_info("%s: unsupport msi, use INTx irq\n",
+ mmc_hostname(host->mmc));
+ return;
+ }
+
+ ret = pci_alloc_irq_vectors(chip->pdev, 1, 1,
+ PCI_IRQ_MSI | PCI_IRQ_MSIX);
+ if (ret < 0) {
+ pr_err("%s: enable PCI MSI failed, err=%d\n",
+ mmc_hostname(host->mmc), ret);
+ return;
+ }
+
+ host->irq = pci_irq_vector(chip->pdev, 0);
+}
+
int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
{
struct sdhci_pci_chip *chip;
@@ -279,6 +302,8 @@ int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
if (reg & 0x1)
host->quirks |= SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12;
+ sdhci_pci_o2_enable_msi(chip, host);
+
if (chip->pdev->device == PCI_DEVICE_ID_O2_SEABIRD0) {
ret = pci_read_config_dword(chip->pdev,
O2_SD_MISC_SETTING, ®);
--
2.7.4
next prev parent reply other threads:[~2018-06-26 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 15:46 [PATCH V6 1/3] mmc: sdhci: Add support for O2 eMMC HS200 mode ernest.zhang
2018-06-26 15:46 ` [PATCH V6 2/3] mmc: sdhci: Add support for O2 hardware tuning ernest.zhang
2018-07-10 12:43 ` Adrian Hunter
2018-06-26 15:46 ` ernest.zhang [this message]
2018-07-10 12:44 ` [PATCH V6 3/3] mmc: sdhci: Add MSI interrupt support for O2 SD host Adrian Hunter
2018-07-10 12:23 ` [PATCH V6 1/3] mmc: sdhci: Add support for O2 eMMC HS200 mode Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626154647.11623-3-ernest.zhang@bayhubtech.com \
--to=ernest.zhang@bayhubtech.com \
--cc=adrian.hunter@intel.com \
--cc=bobby.wu@bayhubtech.com \
--cc=chevron.li@bayhubtech.com \
--cc=chuanjin.pang@bayhubtech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mike.li@bayhubtech.com \
--cc=shirley.her@bayhubtech.com \
--cc=ulf.hansson@linaro.org \
--cc=xiaoguang.yu@bayhubtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).