From: Anisse Astier <anisse@astier.eu>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Anisse Astier <anisse@astier.eu>
Subject: [PATCH v2 1/3] mmc: sdhci-pci: disable 1.8V with dmi quirk
Date: Tue, 23 Oct 2018 12:07:27 +0200 [thread overview]
Message-ID: <20181023100729.28864-2-anisse@astier.eu> (raw)
In-Reply-To: <20181023100729.28864-1-anisse@astier.eu>
In-Reply-To: <20181022134026.GB18413@jaya>
If the motherboard is known not to support 1.8V properly, add the
necessary quirk on probe.
This fixes an issue on a Gemini Lake (GLK) laptop : eMMC driver will
timeout on boot (from 60seconds to 10minutes ) as the cqhci attempts CQE
recovery after a failed voltage switch. In earlier kernels, the problem
existed, but only delayed boot for about 10 seconds after an I/O error,
allowing booting on the eMMC (almost) unnoticed.
Signed-off-by: Anisse Astier <anisse@astier.eu>
---
drivers/mmc/host/sdhci-pci-core.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 7bfd366d970d..396413f7c854 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -29,6 +29,7 @@
#include <linux/mmc/slot-gpio.h>
#include <linux/mmc/sdhci-pci-data.h>
#include <linux/acpi.h>
+#include <linux/dmi.h>
#include "cqhci.h"
@@ -703,6 +704,16 @@ static int intel_execute_tuning(struct mmc_host *mmc, u32 opcode)
return 0;
}
+static const struct dmi_system_id board_no_1_8v[] = {
+ {
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Notebook"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "N75_77GU"),
+ },
+ },
+ { }
+};
+
static void byt_probe_slot(struct sdhci_pci_slot *slot)
{
struct mmc_host_ops *ops = &slot->host->mmc_host_ops;
@@ -710,6 +721,12 @@ static void byt_probe_slot(struct sdhci_pci_slot *slot)
byt_read_dsm(slot);
ops->execute_tuning = intel_execute_tuning;
+
+ if (dmi_check_system(board_no_1_8v)) {
+ pr_debug("%s: motherboard does not support 1.8V\n",
+ mmc_hostname(slot->host->mmc));
+ slot->host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
+ }
ops->start_signal_voltage_switch = intel_start_signal_voltage_switch;
}
--
2.17.2
next prev parent reply other threads:[~2018-10-23 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181018102112.31054-1-anisse@astier.eu>
[not found] ` <88d3fffb-df8d-f29e-f7c1-3bef815435d2@intel.com>
[not found] ` <20181019092513.GA2150@jaya>
[not found] ` <89d02cd8-c910-76fe-3b08-5dd056ba8a11@intel.com>
[not found] ` <20181019134237.GA2762@jaya>
[not found] ` <e329ed2e-75b5-e9f0-04e8-097594003e66@intel.com>
[not found] ` <20181022091436.GA18413@jaya>
[not found] ` <656f1d2e-e27a-cee4-78e1-774e45f067a6@intel.com>
[not found] ` <20181022134026.GB18413@jaya>
2018-10-23 10:07 ` [PATCH v2 0/3] sdhci-pci voltage switch fixes Anisse Astier
2018-10-23 10:07 ` Anisse Astier [this message]
2018-10-23 10:07 ` [PATCH v2 2/3] mmc: sdhci-pci: add new machine with 1.8V dmi quirk Anisse Astier
2018-10-23 10:07 ` [PATCH v2 3/3] mmc: sdhci-pci: only install voltage switch method when useful Anisse Astier
2018-11-16 16:58 ` Anisse Astier
2018-11-19 7:45 ` Adrian Hunter
2018-11-19 9:33 ` Anisse Astier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023100729.28864-2-anisse@astier.eu \
--to=anisse@astier.eu \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox